Code

Toby legend hiding#169

Code

Merged

tdhock merged 20 commits intomasterplotly/plotly.R:masterfrom

toby-legend-hidingplotly/plotly.R:toby-legend-hidingCopy head branch name to clipboard

Mar 3, 2015

Commits

Commits on Feb 23, 2015

• test for legend hiding

  tdhock

  committed
  d3e09ed

  Copy full SHA for d3e09ed

Commits on Feb 24, 2015

• test legend not hidden when unrelated guide is none or FALSE

  tdhock

  committed
  a9b823b

  Copy full SHA for a9b823b

• store generated legends and remove them if guides FALSE or none

  tdhock

  committed
  cd9673a

  Copy full SHA for cd9673a

• merge conflicts

  tdhock

  committed
  0aba7b1

  Copy full SHA for 0aba7b1

Commits on Mar 2, 2015

• test fails for hiding legend entries

  tdhock

  committed
  f63c64a

  Copy full SHA for f63c64a

• test passes for trace with showlegend

  tdhock

  committed
  fcdc44e

  Copy full SHA for fcdc44e

• [a.vec] instead of [[a]]

  tdhock

  committed
  5e4a18d

  Copy full SHA for 5e4a18d

• check length == 1, TODO

  tdhock

  committed
  c070cef

  Copy full SHA for c070cef

• Merge branch 'master' of https://github.com/ropensci/plotly into toby-legend-hiding

  tdhock

  committed
  41c7217

  Copy full SHA for 41c7217

• expect(info) out of for loop

  tdhock

  committed
  8ccbea1

  Copy full SHA for 8ccbea1

• expect_true(trace$showlegend) fails

  tdhock

  committed
  6e8fae9

  Copy full SHA for 6e8fae9

Commits on Mar 3, 2015

• only assign Inf => showlegend=FALSE if breaks manually specified

  tdhock

  committed
  45f8837

  Copy full SHA for 45f8837

• only annotate legend title if at lest one trace with showlegend=TRUE

  tdhock

  committed
  38dafc9

  Copy full SHA for 38dafc9

• any(.) rather than sum(.) > 0

  tdhock

  committed
  ac99b80

  Copy full SHA for ac99b80

• test for showlegend in traces

  tdhock

  committed
  5099a32

  Copy full SHA for 5099a32

• assign trace sort to 1 when there is a legend but no manual breaks

  tdhock

  committed
  474e0bf

  Copy full SHA for 474e0bf

• typo L -> info

  tdhock

  committed
  5e8559d

  Copy full SHA for 5e8559d

• fix more typos

  tdhock

  committed
  6b5e12d

  Copy full SHA for 6b5e12d

• do not consider group aesthetic for making legends

  tdhock

  committed
  5144299

  Copy full SHA for 5144299

• check for waiver when determining default breaks

  tdhock

  committed
  b178933

  Copy full SHA for b178933