Skip to content

Fixes for error bars and ticks #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Feb 23, 2015
Merged

Fixes for error bars and ticks #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
baa31e8
test for error bars first or last
tdhock Jan 27, 2015
adcc2ba
test different colors
tdhock Jan 27, 2015
8169a3d
test only error bars
tdhock Jan 28, 2015
2a37221
only error bars passes test
tdhock Jan 28, 2015
12d8019
error bars after passes test
tdhock Jan 28, 2015
f27f77a
error bars before passes test
tdhock Jan 28, 2015
d907817
colored error bars
tdhock Feb 2, 2015
565102d
colored error bar test fails
tdhock Feb 2, 2015
ea78dc3
symmetric and colored error bar test passes
tdhock Feb 2, 2015
c8e98eb
errorbarh merges, ggplot-errorbar tests pass
tdhock Feb 2, 2015
dea0c1a
fix tile and theme tests
tdhock Feb 2, 2015
1d032af
move back constants
tdhock Feb 4, 2015
c768c2f
tick tests fail
tdhock Feb 5, 2015
f2d7cf3
for discussion
tdhock Feb 9, 2015
eab0348
test y axis range
tdhock Feb 9, 2015
de10b3e
keep marianne additions
tdhock Feb 9, 2015
8062b9c
reverse y axis
tdhock Feb 9, 2015
56e7515
tick tests complete
tdhock Feb 9, 2015
ba1c206
facet tests
tdhock Feb 10, 2015
5cad2f4
disable coord_flip + facet tests
tdhock Feb 11, 2015
3358708
order traces
tdhock Feb 11, 2015
b2f3c11
do not order if there is no order
tdhock Feb 11, 2015
a04c705
flip traces
tdhock Feb 11, 2015
a29a3c7
more breaks, labels, limits tests
tdhock Feb 12, 2015
3047869
scale(labels) for trace names
tdhock Feb 12, 2015
f791134
works with no scale(labels)
tdhock Feb 12, 2015
e2ea24b
breaks=NULL hides ticks, lines, labels
tdhock Feb 12, 2015
7926a30
scale(limits) means axis$range
tdhock Feb 12, 2015
93585b4
get trace range from ggplot range
tdhock Feb 12, 2015
623512e
scale(breaks=numeric) means axis$dtick and autotick
tdhock Feb 12, 2015
8b0a39f
negative reverse scale
tdhock Feb 12, 2015
96f998c
test for correct values with reverse scale
tdhock Feb 12, 2015
2581b0e
multiply by -1 for reversed aes
tdhock Feb 12, 2015
4766545
exclude NA data from traces
tdhock Feb 16, 2015
11522c2
just use is.na not apply
tdhock Feb 17, 2015
5c98619
add save_ouputs
tdhock Feb 17, 2015
314a6ec
explicit theme_grey and fill=NA for readable ggplot
tdhock Feb 17, 2015
a5fa7b2
delete old trace merging code
tdhock Feb 20, 2015
a23b3f2
tests fail for disappearing boxes
tdhock Feb 20, 2015
2742345
test pass, 3 boxes render
tdhock Feb 20, 2015
63b2b71
remove TO DISCUSS
tdhock Feb 20, 2015
7f8ad6c
replace #+ with #
tdhock Feb 20, 2015
5cf9a3c
delete print.trace and trace class
tdhock Feb 20, 2015
c47b802
fix marianne minor comments
tdhock Feb 20, 2015
781f6bf
add space
tdhock Feb 23, 2015
80536ed
delete theme_grey
tdhock Feb 23, 2015
4af13ae
update NEWS/DESCRIPTION
tdhock Feb 23, 2015
cf9d5a4
Remove funny file
mkcor Feb 23, 2015
91a5a45
Revert testthat.R file to latest commit on master
mkcor Feb 23, 2015
3337d85
Revert unrelated test file to latest commit on master
mkcor Feb 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: plotly
Type: Package
Title: Interactive, publication-quality graphs online.
Version: 0.5.20
Version: 0.5.21
Authors@R: c(person("Chris", "Parmer", role = c("aut", "cre"),
email = "[email protected]"),
person("Scott", "Chamberlain", role = "aut",
Expand Down
4 changes: 4 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
0.5.21 -- 23 February 2015.

Fixes for error bars and tick marks.

0.5.20 -- 9 February 2015.

Add alpha transparency to fill conversion.
Expand Down
4 changes: 4 additions & 0 deletions R/corresp_one_one.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,12 @@ coded.lty <- c("22"="dash",
"224282F2"="dash",
"F1"="dash")

# Convert R lty line type codes to plotly "dash" codes.
lty2dash <- c(numeric.lty, named.lty, coded.lty)

# Convert ggplot2 aes to line parameters.
aes2line <- c(linetype="dash",
colour="color",
size="width",
direction="shape")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing white line.

Loading