Better resizing logic #1575
Merged
Better resizing logic #1575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize method, closes #1553
jcheng5
reviewed
Aug 30, 2019
cpsievert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jcheng5 I dug deeper into the root issue behind #1553. It turns out that
Plotly.relayout()mutates input toPlotly.plot()(minimal example). Normally this doesn't pose a problem for resizing logic, but for that dynamic UI example,renderValuegets called twice for every widget (meaningx.layout.width, andinstance.widthis populated during the second render).Anyway, after this discovery, I think it's safer to make a deep copy of
width/height/autosizeat the start ofrenderValue(instead of using attributes attached to the DOM element)