Skip to content

'plotly_selected' is too eager to clear/update #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2018
Merged

'plotly_selected' is too eager to clear/update #1408

merged 2 commits into from
Nov 19, 2018

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Nov 15, 2018 •
edited
Loading

Closes #1121 and #1122

Testing notes

Install (devtools::install_github("ropensci/plotly#1408")) then make sure the examples in the example apps referenced in #1121 and #1122 work as expected

@cpsievert cpsievert changed the title Prevent 'plotly_selected' shiny input from being cleared on click 'plotly_selected' is too eager to clear/update Nov 15, 2018
@cpsievert cpsievert requested a review from jcheng5 November 15, 2018 22:44
jcheng5
jcheng5 approved these changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@jcheng5 jcheng5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this but also seems like something that could/should be fixed in plotly.js?

@cpsievert
Copy link
Collaborator Author

Reported in plotly/plotly.js#3248

@cpsievert cpsievert merged commit 9aa0e86 into master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcheng5 jcheng5 jcheng5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpsievert @jcheng5