Let bargap adapt and fix x-labels in category histograms #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Is it possible to see how the cookbook plots changed, too? |
|
Sure! They should be fixed, because this is what I get, calling |
|
looking good! On Fri, Oct 24, 2014 at 12:37 PM, Marianne Corvellec <
|
mkcor
added a commit
that referenced
this pull request
Oct 24, 2014
Let bargap adapt and fix x-labels in category histograms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes category histograms (bar gap and x-labels).
Before: https://plot.ly/~marianne2/98
After: https://plot.ly/~marianne2/96
Look for JSON changes (i.e.,
test-ggplot-histogram-barmodestack.json,test-ggplot-histogram-binwidth.json,test-ggplot-histogram-dates.json) and corresponding image files, as @chriddyp suggested.I'll increment the package version number after reviews.
/cc @pedrodz