Support geom_vline() conversion #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Split hline and vline when multiple | ||
| if (g$geom == "hline" || g$geom == "vline") { | ||
| if (nrow(g$data) > 1) { | ||
| df.list <- split(basic$data, rep(1:nrow(g$data))) #, drop=TRUE) |
There was a problem hiding this comment.
Oops, this comment should just go away...
|
Great. Fix the comment then |
|
Nice! Looking through the JSON diffs, and then clicking on the associated images with the same filename was a really nice way to review |
|
Awesome! Good to know. :) |
This was referenced Oct 22, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/testthat/test-ggplot-vline-*.png,tests/testthat/test-ggplot-vline-multiple-*.png,tests/testthat/test-ggplot-hline-multiple-*.png;tests/cookbook-test-suite/lines/basic_horizontal_line.*has improved a little, but that's because the original ggplot2 code was broken--now fixed, and I'm not supporting x-ranges that are not numerical--to do;hline_on_facets-*.pngnow fixed (https://plot.ly/~TestBot/690)./cc @pedrodz