Skip to content

restyle 404 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 17, 2020
Merged

restyle 404 #48

merged 4 commits into from
Apr 17, 2020

Conversation

jdamiba
Copy link
Contributor

@jdamiba jdamiba commented Apr 1, 2020

@jdamiba jdamiba requested a review from nicolaskruchten April 1, 2020 00:35
@nicolaskruchten
Copy link
Contributor

Style looks good. Now time to make the content more helpful! Let's get a search box in there somehow if there is /python/ or /javascript/ or /r/ in the URL so they can search our docs directly? Maybe use Javascript to preload the search box with the URL subfragment with hyphens replaced by spaces, along with a "search" button they can click on that will bring up the modal? So like for the URL https://plotly.com/python/datashaader/ (note the extra a) we know they're in Python-land, and maybe searching for datashaader will come up with something? and yes, our search will get them to where they're going!

image

@jdamiba
Copy link
Contributor Author

jdamiba commented Apr 15, 2020

  • get search modal to display on 404 page (change layout to base?)
  • prepopulate search modal with URL
  • if URL contains /python, /javascript, or /r, then provide a link to language index page

@jdamiba
Copy link
Contributor Author

jdamiba commented Apr 16, 2020

@nicolaskruchten I'd like to suggest that we merge this style update on its own.

Adding the search modal to this page is more complicated than I had anticipated and I don't want that work to block this update, which looks more on brand than what we currently have in production.

@nicolaskruchten
Copy link
Contributor

OK, in that case please:

@jdamiba
Copy link
Contributor Author

jdamiba commented Apr 16, 2020

@nicolaskruchten I have updated this PR.

Screenshot:

Screen Shot 2020-04-16 at 7 11 09 PM

@nicolaskruchten
Copy link
Contributor

Can we make the link look more like a link? change color, make it underlined?

@jdamiba
Copy link
Contributor Author

jdamiba commented Apr 17, 2020

Screen Shot 2020-04-17 at 3 22 31 PM

@nicolaskruchten nicolaskruchten merged commit 3a6389a into master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 page rebrand
2 participants