Skip to content

replace homepage hero image #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 26, 2020
Merged

replace homepage hero image #40

merged 4 commits into from
Mar 26, 2020

Conversation

jdamiba
Copy link
Contributor

@jdamiba jdamiba commented Mar 25, 2020 •
edited
Loading

Screen Shot 2020-03-25 at 7 51 32 PM

@jdamiba jdamiba requested a review from nicolaskruchten March 25, 2020 23:52
@nicolaskruchten
Copy link
Contributor

Could you please:

  1. make the whole hero thing shorter, such that the three language cards fit in the same screenful without scrolling?
  2. add a bit of whitespace between the main and sub-titles there inside the hero

@jdamiba
Copy link
Contributor Author

jdamiba commented Mar 26, 2020

I have updated this PR.

Screen Shot 2020-03-26 at 1 09 42 PM

@nicolaskruchten
Copy link
Contributor

Still a little shorter please! it's not all fitting on my laptop screen ;)

image

@nicolaskruchten
Copy link
Contributor

actually i'll fiure out the right height, hang on

@nicolaskruchten
Copy link
Contributor

pushed... can you take a look, LMK what you think?

@jdamiba jdamiba merged commit 4c97388 into master Mar 26, 2020
@jdamiba jdamiba deleted the replace-homepage-hero branch March 26, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaskruchten nicolaskruchten Awaiting requested review from nicolaskruchten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdamiba @nicolaskruchten