Skip to content

fix typos in colorscales #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix typos in colorscales #17

wants to merge 1 commit into from

Conversation

jdamiba
Copy link
Contributor

@jdamiba jdamiba commented Mar 4, 2020

closes #14

@jdamiba jdamiba requested a review from nicolaskruchten March 4, 2020 17:12
@nicolaskruchten
Copy link
Contributor

OK, finally had a chance to look at this... if you could resubmit a PR that doesn't touch the python or python/v3 docs or any ipynb files I would prefer that. These edits are changing the inline JS files!

@nicolaskruchten
Copy link
Contributor

@jdamiba if you can address my comment above we can close this one out :)

@jdamiba jdamiba mentioned this pull request Apr 27, 2020
Merged
@jdamiba
Copy link
Contributor Author

jdamiba commented Apr 27, 2020

superseded by #68

@jdamiba jdamiba closed this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaskruchten nicolaskruchten Awaiting requested review from nicolaskruchten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong colorscales YIOrRd and YIGnBu
2 participants
@jdamiba @nicolaskruchten