Skip to content

Updates to R docs #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Updates to R docs #213

wants to merge 6 commits into from

Conversation

cpsievert
Copy link
Contributor

Just after I made all these changes, I remembered this consequence of using htmlwidgets. So, I’m not sure how exactly md -> html happens, but most likely it's gonna require a messy hack to embed these graphs client-side. :(

@cpsievert
Copy link
Contributor Author

cc @chriddyp

@chriddyp
Copy link
Member

@cpsievert - can we still keep an option for printing the object as an iframe with plotly_POST?

```{r}
f <- plotly_POST(p, filename = "r-docs/midwest-boxplots")
class(f)
f
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @cpsievert - this doesn't seem to work for me:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, you'll need this devtools::install_github("ropensci/plotly#296")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, great, thanks
image

@cpsievert
Copy link
Contributor Author

can we still keep an option for printing the object as an iframe with plotly_POST?

I added that in plotly/plotly.R@350b582 (that pull request - plotly/plotly.R#296 - is ready to merge, BTW)

@cpsievert
Copy link
Contributor Author

Actually, thanks to this post, it might not be too bad to make htmlwidgets play nicely with Jekyll

@chriddyp
Copy link
Member

sweet. I merged this into #215, so I'm going to close this and merge the other one.

@chriddyp chriddyp closed this Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants