Bump Plotly.js to v1.58.0

[archmoj]

Similar to #875.

@Marc-Andre-Rivet
Here are some TODOs:

• please update CHANGELOG in respect to https://github.com/plotly/plotly.js/releases/tag/v1.58.0
• please check if you get the same diff for package-lock.json?
• watch out as it is my very first PR to this repo.
  Thanks!

cc: @nicolaskruchten @alexcjohnson

[Marc-Andre-Rivet]

@archmoj

please check if you get the same diff for package-lock.json?

Looks good. Assuming you've run npm ci followed by npm install --save --exact [email protected]

[archmoj]

@archmoj

please check if you get the same diff for package-lock.json?

Looks good. Assuming you've run npm ci followed by npm install --save --exact [email protected]

No. I run npm i.

[Marc-Andre-Rivet]

No. I run npm i.

@archmoj 😮 - Revalidated, I get the same result as you if I run npm ci + bump Plotly.js locally so the lockfile in this PR is 👌 but I don't understand why. If I run npm i + bump Plotly.js I get additional changes.

Maybe this has to do with npm==6.14.9 in your environment. Will investigate a bit. But this PR is ready to be merged in any case.

[Marc-Andre-Rivet]

💃 @archmoj Thanks!

[archmoj]

Some of the strange diffs in package-lock was related to different version of tape.

plotly.js

dash-core

Should we do something about it?

[Marc-Andre-Rivet]

@archmoj I've always seen many nested deps being updated here but never thought much it, just assumed they are coming from Plotly.js or one of its deps - that said we consume the built Plotly.js package so differences here should have no impact.

If <named_dep> is a direct dependency of Plotly.js using the exact version might help for consistency, but this inconsistency should have no impact based on our usage.

[archmoj]

@archmoj I've always seen many nested deps being updated here but never thought much it, just assumed they are coming from Plotly.js or one of its deps - that said we consume the built Plotly.js package so differences here should have no impact.

If <named_dep> is a direct dependency of Plotly.js using the exact version might help for consistency, but this inconsistency should have no impact based on our usage.

We used to change various dependencies in the past but not quite this time.
Concerning tape module I have this PR open: mikolalysenko/boundary-cells#1
@alexcjohnson could you please ping Mikola there?

[alexcjohnson]

Heh ok, @archmoj thanks for nailing down where those packages come from. Would be nice to clean up at some point (and yes, I'll nudge Mikola re: tape) but for now this seems fine. 💃

[archmoj]

@Marc-Andre-Rivet
I am not authorized to merge this pull request.
Please merge it when you want.

[Marc-Andre-Rivet]

@archmoj I'll update the branch policy to allow core-contributors to merge in core repos. Current policy is arguably a bit too strict since it's already protected by mandatory codeowners review.

[archmoj]

@archmoj I'll update the branch policy to allow core-contributors to merge in core repos. Current policy is arguably a bit too strict since it's already protected by mandatory codeowners review.

"strict" is good.

[Marc-Andre-Rivet]

@archmoj But too strict isn't always :)