Skip to content

change Mabox to Mapbox in GenericChartExtensions, 2 uses in CSharpConsole tests, 2 RELEASE_NOTES.md #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2023
Merged

change Mabox to Mapbox in GenericChartExtensions, 2 uses in CSharpConsole tests, 2 RELEASE_NOTES.md #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Plotly.NET.CSharp/GenericChartExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ public static GenericChart.GenericChart WithYAxisStyle<MinType, MaxType, Categor
/// <param name="gChart">The chart in which to change the mapbox</param>
/// <param name="mapbox">The Mapbox to set on the chart's layout</param>
/// <param name="Id">The target mapbox id on which the Mapbox should be set. Default is 1.</param>
public static GenericChart.GenericChart WithMabox(
public static GenericChart.GenericChart WithMapbox(
this GenericChart.GenericChart gChart,
Mapbox mapbox,
Optional<int> Id = default
Expand All @@ -324,7 +324,7 @@ public static GenericChart.GenericChart WithMabox(
/// <param name="Pitch">Sets the pitch angle of the map (in degrees, where "0" means perpendicular to the surface of the map) (mapbox.pitch).</param>
/// <param name="Layers">Sets the layers of this Mapbox</param>
/// <param name="Id">The target mapbox id</param>
public static GenericChart.GenericChart WithMaboxStyle(
public static GenericChart.GenericChart WithMapboxStyle(
this GenericChart.GenericChart gChart,
Optional<Domain> Domain = default,
Optional<string> AccessToken = default,
Expand Down
4 changes: 2 additions & 2 deletions src/Plotly.NET.CSharp/RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ added C# bindings for statistical charts
Optional arguments are now wrapped in a custom `Optional<T>` type to allow usage of both reference and value types for optional arguments across the whole API.

Some GenericChart extension methods were also added:
- WithMabox
- WithMaboxStyle
- WithMapbox
- WithMapboxStyle

### 0.0.1 - June 15 2022

Expand Down
4 changes: 2 additions & 2 deletions tests/Plotly.NET.Tests.CSharpConsole/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ static void Main(string[] args)
Name: "bubblemapbox"
),
}
).WithMaboxStyle(
).WithMapboxStyle(
Style: MapboxStyle.OpenStreetMap,
Id: 38
).WithTraceInfo(
Expand All @@ -531,7 +531,7 @@ static void Main(string[] args)
longitudes: new int [] { 1,2,2,2,3,4,5,5 },
latitudes: new int [] { 1,2,2,2,3,4,5,5 },
ShowScale: false
).WithMaboxStyle(
).WithMapboxStyle(
Style: MapboxStyle.OpenStreetMap,
Id: 39
).WithTraceInfo(
Expand Down