Skip to content

Fix: typo on sankey chart parameter 'nodeThickness' #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

MMagueta
Copy link
Contributor

Purpose of this PR

Patches the typo on 'nodeThicknes' parameter @ SankeyExtension.

Copy link
Contributor

@WhiteBlackGoose WhiteBlackGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ; since we're anyway renaming all our optional parameters to PascalCase, it's not a breaking change

@kMutagene
Copy link
Collaborator

@WhiteBlackGoose More like "since we are breaking this anyways, we can also break it now" :D thanks for the catch @MMagueta !

@WhiteBlackGoose
Copy link
Contributor

@WhiteBlackGoose More like "since we are breaking this anyways, we can also break it now" :D

Yes, exactly! XD

@kMutagene kMutagene merged commit 426c32d into plotly:dev Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants