Error boundary example fix #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrwitek
requested changes
Apr 28, 2019
| <button | ||
| type="button" | ||
| onClick={() => { | ||
| // We don't just throw the error here, because error boundaries |
There was a problem hiding this comment.
I would prefer just:
Error boundaries catch errors during rendering and do not work inside event handlers:
There was a problem hiding this comment.
Tbh, I think that comment will just confuse whoever is reading through the example. I removed the comment altogether now.
| </button > | ||
| ); | ||
| const BrokenButton = () => { | ||
| const [throwError, setThrowError] = useState(false); |
There was a problem hiding this comment.
Please rename throwError to shouldRenderBrokenComponent
There was a problem hiding this comment.
The line became quite long because of [shouldRenderBrokenComponent, setShouldRenderBrokenComponent]
so I think setShouldBreak would be a better name.
piotrwitek
approved these changes
Apr 28, 2019
|
LGTM, thanks @mathiassoeholm 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error boundary example.
I've added a comment explaining why we can't just throw the error from the event handler.
I hope the example is not too complex now. We can remove the comment, if you think it's too distracting?
I think it's better than having an example that doesn't work though. I ended up spending quite a bit of time figuring out why my error boundary wouldn't work, because of it.