📖Update to use FC and not SFC

[Pau1fitz]

DefinitelyTyped/DefinitelyTyped#30364

[piotrwitek]

Hey, that improvement looks cool!

Please remember about: https://github.com/piotrwitek/react-redux-typescript-guide/blob/master/CONTRIBUTING.md

I can lend a hand during weekend with rebuilding generated code for examples etc.

[piotrwitek]

Hey @Pau1fitz did it already landed on @types? How about SFC, will it still be supported or the new @types will be breaking all SFC usages?

[Pau1fitz]

Hey @piotrwitek, I tried to run the changes through the contributing guideline stages over the weekend, but had some issues. they are just deprecated at the moment, but still work. Would be good to update this guide though as a lot of people use this resource. You can see that this guide uses FunctionComponent.

[piotrwitek]

Got it, the reason I'm asking is I was trying it like a few days ago and FC was not part of react types.

I'll try again

[Pau1fitz]

cool, let me know 👍🏼

[piotrwitek]

OK, checked and working fine.

One more thing, could you please change all instances of "Stateful components" to "Class components"? As of now this distinction will make more sense.

[piotrwitek]

functional counter is a bit confusing name, let's name it "counter component"

[Pau1fitz]

sure, sounds good. I just changed it as stateless is no longer the term being used. are you happy for me to do it in this PR, as I said I was having issues with the instructions in the contributing guidelines - it wasn't working  😯

[piotrwitek]

Yea sure.
Could you also post what was the issue with contributing guide as I would like to fix that.
Thanks

[Pau1fitz]

Changes updated.

The issue with the contributing guide that I am having is in relation to step 2:

# run type-checking in `/playground` folder
npm run tsc

Lots of errors:

[piotrwitek]

Changes updated.

The issue with the contributing guide that I am having is in relation to step 2:

# run type-checking in `/playground` folder
npm run tsc

Lots of errors:
...

Thanks.
I guess errors have something to do with how you installed your dependencies, because on clean install there aren't any errors.

Did you install dependencies with npm at least [email protected] to respect package-lock?

[Pau1fitz]

I am using npm v 6.4.1

[piotrwitek]

Have you tried to rm -rf node_modules and then do a clean install?

[piotrwitek]

Rebased your work on master, updated readme-source, updated source files in playground, updated styleguidist webpage.

Merged in #124 & #125

[Pau1fitz]

thanks @piotrwitek good work

[piotrwitek]

@Pau1fitz Thanks for the initial work! I wanted to retain your contribution but when I squashed and merged the PR github didn't honored it. Sorry for that I will need to check some guide how to do it properly next time.

[Pau1fitz]

will have to make another PR 😁🤓