Skip to content

Improve HOC spread #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
piotrwitek opened this issue Oct 31, 2018 · 3 comments · Fixed by #163
Closed

Improve HOC spread #101

piotrwitek opened this issue Oct 31, 2018 · 3 comments · Fixed by #163
Assignees
@piotrwitek
Labels
enhancement IssueHunt

Comments

@piotrwitek
Copy link
Owner

piotrwitek commented Oct 31, 2018 •
edited
Loading

TypeScript have known issues with rest props syntax in React components using generic Props argument.

Come back when HOC generics issue is fixed and fix below HOC examples:
https://github.com/piotrwitek/react-redux-typescript-guide/blob/master/playground/src/hoc/with-state.tsx#L37
https://github.com/piotrwitek/react-redux-typescript-guide/blob/master/playground/src/hoc/with-error-boundary.tsx#L41
@piotrwitek piotrwitek self-assigned this Oct 31, 2018
@piotrwitek piotrwitek mentioned this issue Dec 3, 2018
Closed
@IssueHuntBot
Copy link

@issuehuntfest has funded $20.00 to this issue. See it on IssueHunt

@piotrwitek piotrwitek added the blocked upstream issue label Feb 12, 2019
@IssueHuntBot
Copy link

@IssueHunt has funded $20.00 to this issue.

@piotrwitek piotrwitek removed the blocked upstream issue label Apr 22, 2019
piotrwitek added a commit that referenced this issue Apr 22, 2019
@piotrwitek
Removed HOC rest props workaround found fixed in recent TSResolved #101
8b9df23
@piotrwitek piotrwitek mentioned this issue Apr 22, 2019
Merged
piotrwitek added a commit that referenced this issue Apr 22, 2019
@piotrwitek
Removed HOC rest props workaround found fixed in recent TSResolved #101…
0ca081e 
… (#163)
@IssueHuntBot
Copy link

@piotrwitek has rewarded $28.00 to @piotrwitek. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(20%): $8.00
  • 🔧 Service fee(10%): $4.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotrwitek piotrwitek

Labels
enhancement IssueHunt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed HOC rest props workaround found fixed in recent TS piotrwitek/react-redux-typescript-guide
2 participants
@piotrwitek @IssueHuntBot