Skip to content

parameter skipping patch - phase 1 #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions Zend/tests/default_params01.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
--TEST--
Default parameters - 1
--FILE--
<?php
function test($a=1, $b=2, $c=3) {
var_dump($a, $b, $c);
var_dump(func_get_args());
}
echo "7\n";
test(7);
echo "default,4,5\n";
test(default,4,5);
echo "default,default,8\n";
test(default,default,8);
echo "3,default,5\n";
test(3,default,5);
echo "3,default,7,default,6\n";
test(3,default,7,default,6);
?>
--EXPECTF--
7
int(7)
int(2)
int(3)
array(1) {
[0]=>
int(7)
}
default,4,5
int(1)
int(4)
int(5)
array(3) {
[0]=>
int(1)
[1]=>
int(4)
[2]=>
int(5)
}
default,default,8
int(1)
int(2)
int(8)
array(3) {
[0]=>
int(1)
[1]=>
int(2)
[2]=>
int(8)
}
3,default,5
int(3)
int(2)
int(5)
array(3) {
[0]=>
int(3)
[1]=>
int(2)
[2]=>
int(5)
}
3,default,7,default,6

Fatal error: Defaults can be used only for declared optional parameters in %s line %d
43 changes: 43 additions & 0 deletions Zend/tests/default_params02.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
--TEST--
Default parameters - 2
--FILE--
<?php
function foo($a, $b=1, $c=2, $d = 3) {
var_dump($a, $b, $c, $d);
var_dump(func_num_args());
var_dump(func_get_args());
}

foo(1,2,3);
foo(1,default,3);
foo(default,2,3);
?>
--EXPECTF--
int(1)
int(2)
int(3)
int(3)
int(3)
array(3) {
[0]=>
int(1)
[1]=>
int(2)
[2]=>
int(3)
}
int(1)
int(1)
int(3)
int(3)
int(3)
array(3) {
[0]=>
int(1)
[1]=>
int(1)
[2]=>
int(3)
}

Fatal error: Defaults can be used only for declared optional parameters in %s line %d
21 changes: 21 additions & 0 deletions Zend/tests/default_params03.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
--TEST--
Default parameters - 3
--FILE--
<?php
function test($a=1, $b=2, $c=3) {
var_dump(func_get_args());
var_dump(func_get_arg(1));
}

test(7,default);
echo "Done\n";
?>
--EXPECTF--
array(2) {
[0]=>
int(7)
[1]=>
int(2)
}
int(2)
Done
50 changes: 50 additions & 0 deletions Zend/tests/default_params04.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
--TEST--
Default parameters - 4, call_user_func
--FILE--
<?php
function foo($a, $b=1, $c=2, $d = 3) {
var_dump($a, $b, $c, $d);
var_dump(func_num_args());
var_dump(func_get_args());
echo "==\n";
}

call_user_func('foo', 1,default,5,6);
call_user_func('foo', 0,default,7,default);
//call_user_func_array('foo', array(42, 2=>43, 4=>44));
echo "Done\n";
?>
--EXPECTF--
int(1)
int(1)
int(5)
int(6)
int(4)
array(4) {
[0]=>
int(1)
[1]=>
int(1)
[2]=>
int(5)
[3]=>
int(6)
}
==
int(0)
int(1)
int(7)
int(3)
int(4)
array(4) {
[0]=>
int(0)
[1]=>
int(1)
[2]=>
int(7)
[3]=>
int(3)
}
==
Done
20 changes: 20 additions & 0 deletions Zend/tests/default_params05.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
--TEST--
Default parameters - 5
--FILE--
<?php
function test($a=1, $b=2, $c=3) {
debug_print_backtrace();
}

test(7);
test(default,4,5);
test(default,default,8);
test(3,default,5);
echo "Done\n";
?>
--EXPECTF--
#0 test(7) called at [%s:%d]
#0 test(1, 4, 5) called at [%s.php:%d]
#0 test(1, 2, 8) called at [%s:%d]
#0 test(3, 2, 5) called at [%s:%d]
Done
19 changes: 19 additions & 0 deletions Zend/tests/default_params06.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
--TEST--
Default parameters - 6, by-refs
--FILE--
<?php
function test($a=1, &$b=2) {
var_dump($a, $b);
$b = 10;
}

test(7);
test(7, default);
echo "Done\n";
?>
--EXPECTF--
int(7)
int(2)
int(7)
int(2)
Done
22 changes: 22 additions & 0 deletions Zend/tests/default_params07.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
--TEST--
Default parameters - 7, by-refs
--FILE--
<?php
if(time()) {
// make the function unknown at compile-time
function test($a=1, &$b=2) {
var_dump($a, $b);
$b = 10;
}
}
test(7);
test(7, default);
echo "Done\n";
?>
--EXPECTF--
int(7)
int(2)
int(7)
int(2)
Done

16 changes: 16 additions & 0 deletions Zend/tests/default_params08.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
--TEST--
Default parameters - 8, by-refs
--FILE--
<?php

var_dump(is_callable("is_callable", default, default));
$test = "";
var_dump(is_callable("is_not_callable", default, $test));
var_dump($test);
echo "Done\n";
?>
--EXPECTF--
bool(true)
bool(false)
string(15) "is_not_callable"
Done
42 changes: 42 additions & 0 deletions Zend/tests/default_params09.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
--TEST--
Default parameters - 9, internal funcs
--FILE--
<?php
var_dump(array_chunk([1,2,3,4], 2));
var_dump(array_chunk([1,2,3,4], 2, default));
echo "Done\n";
?>
--EXPECTF--
array(2) {
[0]=>
array(2) {
[0]=>
int(1)
[1]=>
int(2)
}
[1]=>
array(2) {
[0]=>
int(3)
[1]=>
int(4)
}
}
array(2) {
[0]=>
array(2) {
[0]=>
int(1)
[1]=>
int(2)
}
[1]=>
array(2) {
[0]=>
int(3)
[1]=>
int(4)
}
}
Done
24 changes: 24 additions & 0 deletions Zend/tests/default_params10.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
--TEST--
Default parameters - 10, shutdown func
--FILE--
<?php
function test($a=1, $b=2, $c=3) {
var_dump($a, $b, $c);
var_dump(func_get_args());
}
register_shutdown_function("test", 3, default, 1);
echo "Done\n";
?>
--EXPECTF--
Done
int(3)
int(2)
int(1)
array(3) {
[0]=>
int(3)
[1]=>
int(2)
[2]=>
int(1)
}
33 changes: 33 additions & 0 deletions Zend/tests/default_params11.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
--TEST--
Default parameters - 11, call_user_func
--FILE--
<?php
function foo($a, $b=1, &$c=2, $d = 3) {
$c++;
var_dump($a, $b, $c, $d);
var_dump(func_num_args());
var_dump(func_get_args());
echo "==\n";
}

call_user_func('foo', 5, 6, default, 8);
echo "Done\n";
?>
--EXPECTF--
int(5)
int(6)
int(3)
int(8)
int(4)
array(4) {
[0]=>
int(5)
[1]=>
int(6)
[2]=>
int(3)
[3]=>
int(8)
}
==
Done
16 changes: 16 additions & 0 deletions Zend/tests/default_params12.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
--TEST--
Default parameters - 12, call_user_func
--FILE--
<?php
function foo($a, $b=1, $c=2, $d = 3) {
var_dump($a, $b, $c, $d);
var_dump(func_num_args());
var_dump(func_get_args());
echo "==\n";
}

call_user_func('foo', default, default,5,6);
echo "Done\n";
?>
--EXPECTF--
Fatal error: Defaults can be used only for declared optional parameters in %s line %d
Loading