Implement the negative_array_index RFC #3772
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Jan 30, 2019
pmmaga
force-pushed
the
negative-next-index-8
branch
from
e2c2f6a to
142a0e3
Compare
|
Now that I noticed that we don't have the |
pmmaga
force-pushed
the
negative-next-index-8
branch
from
1987fca to
92f3541
Compare
|
Not sure if we'll be using milestones for other cases as well. If yes, we will probably need that. |
|
@carusogabriel We don't really use Github fully so things like Milestones are not a thing here. I believe we did tag PRs for versions at one point, but I could be wrong |
|
@carusogabriel I've added you to the GH org. Generally, it's best not to manage labels via the QA interface, as the generated notifications are annoying to everyone else. |
nikic
reviewed
Feb 5, 2019
pmmaga
force-pushed
the
negative-next-index-8
branch
from
92f3541 to
9eee682
Compare
pmmaga
force-pushed
the
negative-next-index-8
branch
from
9eee682 to
319fddf
Compare
|
This looks fine to me. @dstogov Anything to add? |
|
looks fine for me too. |
|
Merged as 6732028 |
Totktonada
pushed a commit
to mikhainin/tarantool-php
that referenced
this pull request
Apr 11, 2022
The `nNextFreeElement` field is initialized with `ZEND_LONG_MIN` instead of zero since PHP 8.0. Adjust our `php_mp_is_hash()` check accordingly. See [1] and [2] for details. NB: PHP 8.1 introduces `zend_array_is_list()`, which may be used here. See [3] and [4] for details. [1]: https://wiki.php.net/rfc/negative_array_index [2]: php/php-src#3772 [3]: https://wiki.php.net/rfc/is_list [4]: php/php-src#6070 Since I don't observe any other problems on PHP 8.1, closing the relevant issue. Fixes tarantool#171
Totktonada
pushed a commit
to tarantool/tarantool-php
that referenced
this pull request
Apr 11, 2022
The `nNextFreeElement` field is initialized with `ZEND_LONG_MIN` instead of zero since PHP 8.0. Adjust our `php_mp_is_hash()` check accordingly. See [1] and [2] for details. NB: PHP 8.1 introduces `zend_array_is_list()`, which may be used here. See [3] and [4] for details. [1]: https://wiki.php.net/rfc/negative_array_index [2]: php/php-src#3772 [3]: https://wiki.php.net/rfc/is_list [4]: php/php-src#6070 Since I don't observe any other problems on PHP 8.1, closing the relevant issue. Fixes #171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for https://wiki.php.net/rfc/negative_array_index