update css for 404 pages to not look like we are in 1995 and have a cons... #240
Conversation
|
updated the pull request to also highlight the query that is 404: |
|
It's a minor change, but it certainly does look a lot better. |
| @@ -280,8 +280,10 @@ | |||
| * copied from ext/standard/info.c | |||
| */ | |||
| static const char php_cli_server_css[] = "<style>\n" \ | |||
| "body { background-color: #ffffff; color: #000000; }\n" \ | |||
| "h1 { font-family: sans-serif; font-size: 150%; background-color: #9999cc; font-weight: bold; color: #000000; margin-top: 0;}\n" \ | |||
| "body { background-color: #FCFCFC; color: #333333; margin: 0; padding:0; }\n" \ | |||
There was a problem hiding this comment.
There does appear to be a preference (in this file and elsewhere) for lowercase letters in hex color codes.
|
Updated pull request to use lowercase HEX values and resync with master |
|
Is there anything else I should do to get that pull request accepted? |
|
Could you please squash the commits? |
|
OK, I think I failed squashing my commits and just destroyed my branch :/ I am going to recreate a branch and redo the pull request |
|
No need to open a new one. Just reopen and push with --force. |
|
It doesn't work, I only end up making noise in your repo :/ |
update css for 404 pages to not look like we are in 1999 and have a consistent layout across browsers.
Here is a before/after screenshot:
http://chevrel.org/images/phpbugs/bug63242v2_compare.png
Margins/paddings are explicitely set and no longer depend on browser defaults, better readability of fonts while keeping the typical PHP-blue background color on h1.
I don't think it's possible to add a test for that pull request since it is fixing an esthaetics problem to make look the PHP integrated server more visually appealing for people like me that use it a lot.