Fix GH-12104 attempt #14311
Closed
Fix GH-12104 attempt #14311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-lb
approved these changes
May 24, 2024
bukka
requested changes
May 24, 2024
|
Ideally it would be better to rewrite with select but guess it might require more time so not asking for that. |
|
It may be worth it to try select() if it's a two lines change, as it would make the test faster than with sleep(), and more reliable. |
bukka
reviewed
May 24, 2024
| stream_socket_recvfrom($server, 1, 0, $peer); | ||
| stream_socket_sendto($server, $data, 0, $peer); | ||
| if (stream_select($read, $write, $exc, 0, 250000) === false) die ("stream_select timeout"); |
There was a problem hiding this comment.
shouldn't $read be set to [$fd]?
using stream_select to gives the chance to process the data.
devnexen
force-pushed
the
update_bug74090_test
branch
from
56b36fe to
baa9132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a bit of latency to give time to receive the data.