Update DOM test to work around libxml2 bug #12026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in phpGH-12024, the test fails in the encoding part of the test file. This is due to a libxml2 bug (that's been fixed in modern versions, but of course various systems and distros are always behind). The goal of this part of the test is to check if an encoding declaration is outputted. So the actual encoding used doesn't matter. Switch to UTF-8, which seems to always work, to work around the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in GH-12024, the test fails in the encoding part of the test file. This is due to a libxml2 bug (that's been fixed in modern versions, but of course various systems and distros are always behind). The goal of this part of the test is to check if an encoding declaration is outputted. So the actual encoding used doesn't matter. Switch to UTF-8, which seems to always work, to work around the issue.