Skip to content

Show a currency #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2020
Merged

Show a currency #1391

merged 1 commit into from
May 18, 2020

Conversation

bahoss
Copy link
Contributor

@bahoss bahoss commented May 12, 2020 •
edited by php-coder
Loading

Fixes #1388

@bahoss bahoss requested a review from php-coder as a code owner May 12, 2020 19:30
@mystamps-bot
Copy link

mystamps-bot commented May 12, 2020 •
edited
Loading

1 Message
📖 @bahoss thank you for the PR! All quality checks have been passed! Next step is to wait when @php-coder will review this code

Generated by 🚫 Danger

php-coder
php-coder requested changes May 12, 2020
View reviewed changes
Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

See my comments and also don't forget to update ResourceUrl.RESOURCES_VERSION as requested by our bot.

@bahoss bahoss force-pushed the show-a-currency branch from 29efb6e to 6993593 Compare May 14, 2020 12:14
php-coder
php-coder requested changes May 17, 2020
View reviewed changes
Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and I'm sorry for a delay on my side. See my comments!

@bahoss bahoss force-pushed the show-a-currency branch from 6993593 to 7bc5645 Compare May 17, 2020 17:07
@bahoss bahoss force-pushed the show-a-currency branch from 7bc5645 to ea5fecf Compare May 17, 2020 17:59
php-coder
php-coder approved these changes May 18, 2020
View reviewed changes
Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 👍

@php-coder php-coder merged commit ea5fecf into php-coder:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@php-coder php-coder php-coder approved these changes

Assignees
No one assigned
Labels
resolution/merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AddCatalogPriceForm: show a currency
4 participants
@bahoss @mystamps-bot @php-coder @0pdd