Add country form to React #1360
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Closed
php-coder
requested changes
Apr 22, 2020
| @@ -73,43 +73,8 @@ <h3 th:text="${#strings.capitalize(add_country)}"> | |||
| </small> | |||
| </div> | |||
|
|
|||
| <form id="add-country-form" method="post" class="form-horizontal" action="info.html" | |||
There was a problem hiding this comment.
We shouldn't remove the form in this PR. Everything should continue to work until we fully re-implement existing logic.
Can we try to render the component into id="add-country-form" or we need a separate element for that?
| super(props); | ||
| this.state = { | ||
| nameInEnglish: "", | ||
| nameInRussian: "" |
There was a problem hiding this comment.
Please, prefer single quotes over double one.
| axios.post( | ||
| "categories",{},{} | ||
| ).then(response => { | ||
|
|
There was a problem hiding this comment.
Do you plan to implement this logic?
| type="text" | ||
| className="form-control" | ||
| value={this.state.nameInEnglish} | ||
| name="nameInEnglish" |
There was a problem hiding this comment.
Is this "name" attribute is needed for event.target.name?
| @@ -0,0 +1,89 @@ | |||
| class AddCountryForm extends React.Component { | |||
There was a problem hiding this comment.
Could you prepend a comment like this?
| <div className="col-sm-offset-4 col-sm-5"> | ||
| <input type="submit" | ||
| className="btn btn-primary" | ||
| value="Add" /* th:value="#{t_add}" */ /> |
There was a problem hiding this comment.
We should add localization and convert it into a button. Like there:
mystamps/src/main/frontend/src/components/SimilarSeriesForm.js
Lines 105 to 109 in 778dc2a
| onChange={this.handleChange} /* th:field="*{nameRu}" */ /> | ||
| {/* | ||
| <span id="nameRu.errors" class="help-block" th:if="${#fields.hasErrors('nameRu')}" th:each="error : ${#fields.errors('nameRu')}" th:text="${error}"></span> | ||
| */} |
There was a problem hiding this comment.
Should be implemented like there:
mystamps/src/main/frontend/src/components/SimilarSeriesForm.js
Lines 111 to 113 in 778dc2a
|
|
||
| <div className="form-group" /* th:classappend="${#fields.hasErrors('nameRu') ? 'has-error' : ''}" */> | ||
| <label htmlFor="nameRu" className="control-label col-sm-4" /* th:text="#{t_name_in_russian}" */> | ||
| Name (in Russian) |
There was a problem hiding this comment.
Localization should be supported.
| className="form-control" | ||
| value={this.state.nameInRussian} | ||
| name="nameInRussian" | ||
| onChange={this.handleChange} /* th:field="*{nameRu}" */ /> |
There was a problem hiding this comment.
Suggested change
| onChange={this.handleChange} /* th:field="*{nameRu}" */ /> | |
| onChange={this.handleChange} /> |
| value={this.state.nameInEnglish} | ||
| name="nameInEnglish" | ||
| required="required" | ||
| onChange={this.handleChange} /* th:field="*{name}" */ /> |
There was a problem hiding this comment.
Suggested change
| onChange={this.handleChange} /* th:field="*{name}" */ /> | |
| onChange={this.handleChange} /> |
|
@splin-shady Hi, please, let me know if you need help or if you aren't going to work on this PR. Thanks! |
|
I'm closing this PR due to inactivity. Please, let me know if you want to continue this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address to #1345