Skip to content

SeriesSalesImportServiceImpl.saveParsedData(): add unit tests #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0pdd opened this issue Feb 3, 2018 · 0 comments
Closed

SeriesSalesImportServiceImpl.saveParsedData(): add unit tests #834

0pdd opened this issue Feb 3, 2018 · 0 comments
Assignees
@php-coder
Labels
area/unit tests techdebt
Milestone
0.4

Comments

@0pdd
Copy link

0pdd commented Feb 3, 2018

The puzzle 695-ebcd7a3c from #695 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/service/SeriesSalesImportServiceImpl.java

Line 38 in 0814b35

// @todo #695 SeriesSalesImportServiceImpl.saveParsedData(): add unit tests

The puzzle was created by Slava Semushin on 04-Jan-18.

Estimate: 0 minutes, role: IMP.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd 0pdd added the techdebt label Feb 3, 2018
0pdd referenced this issue Feb 3, 2018
@php-coder
Import series: add support for extracting info about price and known …
0814b35 
…seller.

This commit adds new configuration properties:
- app.site-parser[x].seller-locator
- app.site-parser[x].price-locator
- app.site-parser[x].currency-value

Addressed to #695
@php-coder php-coder self-assigned this Feb 7, 2018
@php-coder php-coder added this to the 0.4 milestone Feb 7, 2018
@0pdd 0pdd mentioned this issue Feb 7, 2018
Open
php-coder added a commit that referenced this issue Feb 7, 2018
@php-coder
SeriesSalesImportServiceImplTest: improve test name.
57a79a8 
Should be in f17ff2b commit.

Addressed to #834

No functional changes.
@0pdd 0pdd mentioned this issue Jul 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/unit tests techdebt
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @0pdd