Skip to content

Use fixed currency for michel/scott/yvert/gibbons catalogs #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Dec 29, 2017 · 1 comment
Closed

Use fixed currency for michel/scott/yvert/gibbons catalogs #778

php-coder opened this issue Dec 29, 2017 · 1 comment
Assignees
@php-coder
Labels
refactoring
Milestone
0.4

Comments

@php-coder
Copy link
Owner

We need to remove the *_currency fields from database and all the related code and always use the static values.
@php-coder php-coder changed the title series: use fixed currency for michel/scott/yvert/gibbons catalogs Use fixed currency for michel/scott/yvert/gibbons catalogs Dec 29, 2017
@php-coder php-coder self-assigned this Jan 4, 2018
@php-coder php-coder added this to the 0.4 milestone Jan 4, 2018
php-coder added a commit that referenced this issue Jan 5, 2018
@php-coder
Remove fixed currency values from service and dao code.
915f84a 
Addressed to #778

No functional changes.
php-coder added a commit that referenced this issue Mar 11, 2018
@php-coder
Remove fixed currency values from database and show series info page.
0081e7a 
Addressed to #778

No functional changes.
@php-coder
Copy link
Owner Author

I've pushed the last commit that completely fixes this issue.

php-coder added a commit that referenced this issue Mar 11, 2018
@php-coder
SeriesServiceImplTest: remove unused import.
410cf50 
Reported by CodeNarc.

Should be in 0081e7a commit.

Addressed to #778

[ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
refactoring
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@php-coder