Skip to content

SeriesImportServiceImpl.findAll(): add unit tests #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0pdd opened this issue Dec 19, 2017 · 0 comments
Closed

SeriesImportServiceImpl.findAll(): add unit tests #764

0pdd opened this issue Dec 19, 2017 · 0 comments
Assignees
@php-coder
Labels
area/unit tests techdebt
Milestone
0.4

Comments

@0pdd
Copy link

0pdd commented Dec 19, 2017

The puzzle 692-5cbccdf5 from #692 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/service/SeriesImportServiceImpl.java

Line 215 in eca110b

// @todo #692 SeriesImportServiceImpl.findAll(): add unit tests

The puzzle was created by Slava Semushin on 19-Dec-17.

Estimate: 0 minutes, role: IMP.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd 0pdd added the techdebt label Dec 19, 2017
0pdd referenced this issue Dec 19, 2017
@php-coder
/series/import/requests: show a list of import requests.
eca110b 
Fix #692
@php-coder php-coder self-assigned this Dec 20, 2017
@php-coder php-coder added this to the 0.4 milestone Dec 20, 2017
php-coder added a commit that referenced this issue Mar 3, 2018
@php-coder
Random.date(): fix incorrect date in range.
88ce689 
Correction for c505b03 commit.

Addressed to #764
php-coder added a commit that referenced this issue Mar 3, 2018
@php-coder
Configure SimpleDateFormat to be strict during date parsing.
a88320f 
This change ensures that I don't do a mistake from c505b03 commit
again.

Addressed to #764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/unit tests techdebt
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @0pdd