Skip to content

DownloadingSucceededEventListener: improve error handling #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
php-coder opened this issue Nov 7, 2017 · 0 comments
Open

DownloadingSucceededEventListener: improve error handling #679

php-coder opened this issue Nov 7, 2017 · 0 comments
Labels

Comments

@php-coder
Copy link
Owner

We should resolve the following TODOs:

String content = importService.getDownloadedContent(requestId);
if (content == null) {
// TODO: how to handle error? maybe publish UnexpectedErrorEvent?
log.error("Request #{}: could not load a content from database", requestId);
return;
}

and

if (parser == null) {
// TODO: how to handle error? maybe publish UnexpectedErrorEvent?
log.error("Request #{}: could not find appropriate parser", requestId);
return;
}

Tech debt for 29f6dc9 (#660)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant