Skip to content

Scott catalog numbers should support letters #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Oct 29, 2017 · 2 comments
Closed

Scott catalog numbers should support letters #671

php-coder opened this issue Oct 29, 2017 · 2 comments
Assignees
@php-coder
Labels
kind/improvement priority/important
Milestone
0.4

Comments

@php-coder
Copy link
Owner

At this time it's impossible to specify numbers like 2317a because we don't accept letters. We should support letters.
@php-coder php-coder added this to the 0.4 milestone Oct 29, 2017
@php-coder
Copy link
Owner Author

Ideally, we should find out a format of valid numbers. Most likely a11, abb aren't valid. Perhaps, we should allow letters only at the end.

@php-coder php-coder mentioned this issue Oct 29, 2017
Closed
php-coder added a commit that referenced this issue Oct 30, 2017
@php-coder
Scott catalog numbers: fix displying of numers with letters.
b6af041 
Addressed to #671
@php-coder php-coder modified the milestones: 0.4, next Jun 13, 2018
@php-coder php-coder modified the milestones: next, 0.4 Dec 1, 2018
@php-coder php-coder self-assigned this Dec 1, 2018
php-coder added a commit that referenced this issue Dec 1, 2018
@php-coder
refactor(CatalogNumbers): use custom validator instead of @pattern.
8cb62db 
Later our implementation will be enhanced to use different patterns and messages for different
catalogs.

Addressed to #671

No functional changes.
@0pdd 0pdd mentioned this issue Dec 1, 2018
Open
@0pdd 0pdd mentioned this issue Dec 1, 2018
Open
@0pdd
Copy link

0pdd commented Dec 1, 2018

@php-coder 2 puzzles #972, #973 are still not solved.

@php-coder php-coder mentioned this issue Dec 1, 2018
Closed
@php-coder php-coder mentioned this issue Mar 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
kind/improvement priority/important
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @0pdd