/suggest/series_country: returns an empty response when there is no suggestion

[php-coder]

When as admin I open /series/add page in Firefox, I see the following error in the developer console:

Ошибка синтаксического анализа XML: корневой элемент не найден
Адрес: http://localhost:8080/suggest/series_country
Строка 1, символ 1:

It turned out that /suggest/series_country returns an empty response. I see that also when I'm getting the response from the terminal:

$ http 'http://localhost:8080/suggest/series_country' Cookie:JSESSIONID=dyhl9vt2dr9g126hsqu0b0ict
HTTP/1.1 200 OK
Content-Length: 0
Date: Tue, 29 Aug 2017 20:43:54 GMT

Here the similar problem on StackOverflow: https://stackoverflow.com/questions/25650356/spring-ajax-responsebody-with-null-returned-values

Based on one of the answers, I think that we should try to return 204 No Content code and handle it accordingly on the client side.

@Shkarin JFYI

[php-coder]

I also was surprised that the response doesn't have Content-Type header. I think that we should add it.

[php-coder]

My current idea is to return an empty string when we can't suggest anything.

[Shkarin]

ты это сделал уже? 2017-09-15 0:41 GMT+05:00 Vyacheslav Semushin <[email protected]>:

…

My current idea is to return an empty string when we can't suggest anything. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#630 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVJDAaJ3ryuq_Jo4faNcWxYHRa5xt_qQks5siYFWgaJpZM4PGhw0> .

[Shkarin]

и второе я так понял из этого #571 ничего не реализовано? 2017-09-24 21:32 GMT+05:00 Евгений Шкарин <[email protected]>:

…

ты это сделал уже? 2017-09-15 0:41 GMT+05:00 Vyacheslav Semushin ***@***.***>: > My current idea is to return an empty string when we can't suggest > anything. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#630 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AVJDAaJ3ryuq_Jo4faNcWxYHRa5xt_qQks5siYFWgaJpZM4PGhw0> > . >

[php-coder]

Нет по обоим вопросам. Назначь на себя и добавь метку in-progress, если хочешь ими заняться.

[Shkarin]

- user who created a series with country should see suggestion of this country findCountryOfLastCreatedSeriesByUser (http://prntscr.com/gp5owz)? - user with a series with country in his collection should have suggestion for this country findPopularCountryInCollection (http://prntscr.com/gp5og5)? - user who didn't create any series and doesn't have series in collection (or has series without country) shouldn't see suggestion link http://prntscr.com/gp5p75 ? Может я ошибаюсь, но вроде тесты уже на все есть, разве нет? 24 сентября 2017 г., 21:56 пользователь Vyacheslav Semushin < [email protected]> написал:

…

Нет по обоим вопросам. Назначь на себя и добавь метку in-progress, если хочешь ими заняться. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#630 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVJDAW7Ego80meHCmvrnxLIcnQzIoOkrks5slomlgaJpZM4PGhw0> .

[Shkarin]

My current idea is to return an empty string when we can't suggest anything. http://prntscr.com/gp61g1 может тут проверку сделаем на нул и будем возвращать пустую строку? 2017-09-24 23:24 GMT+05:00 Евгений Шкарин <[email protected]>:

…

- user who created a series with country should see suggestion of this country findCountryOfLastCreatedSeriesByUser (http://prntscr.com/gp5owz)? - user with a series with country in his collection should have suggestion for this country findPopularCountryInCollection (http://prntscr.com/gp5og5)? - user who didn't create any series and doesn't have series in collection (or has series without country) shouldn't see suggestion link http://prntscr.com/gp5p75 ? Может я ошибаюсь, но вроде тесты уже на все есть, разве нет? 24 сентября 2017 г., 21:56 пользователь Vyacheslav Semushin < ***@***.***> написал: > Нет по обоим вопросам. Назначь на себя и добавь метку in-progress, если > хочешь ими заняться. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#630 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AVJDAW7Ego80meHCmvrnxLIcnQzIoOkrks5slomlgaJpZM4PGhw0> > . >

[php-coder]

Может я ошибаюсь, но вроде тесты уже на все есть, разве нет?

This issue is about integration tests (that are using Selenium) and we only have unit tests right now.

And BTW it's better to discuss the issue in the comments to this issues.

[php-coder]

http://prntscr.com/gp61g1 может тут проверку сделаем на нул и будем возвращать пустую строку?

Yes, let's try this.