-
Notifications
You must be signed in to change notification settings - Fork 34
Build scripts: run checks only when commit changes files with certain type #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If only tests on Groovy were modified then only unit tests and CodeNarc checking should be performed. |
|
I'm going to merge my implementation. Here are some details:
|
Actually, we can run unit tests only when one of these were modified: Anyway, unit test will be run again during publishing code coverage (see #391). |
php-coder
added a commit
that referenced
this issue
Jul 30, 2017
bodom91
pushed a commit
to bodom91/mystamps
that referenced
this issue
Aug 2, 2017
…t modified. Now the checks will be run only when the files with the following patterns were modified: - sortpom: pom.xml - enforcer: pom.xml - checkstyle: pom.xml, *.java, *.properties, checkstyle.xml, checkstyle-suppressions.xml - findbugs: pom.xml, *.java, findbugs-filter.xml - pmd: pom.xml, *.java, pmd.xml - unit tests: pom.xml, *.java, *.groovy - license: pom.xml, *.java, *.groovy, license_header.txt - codenarc: pom.xml, *.groovy - jasmine: pom.xml, *.js - rflint: .travis.yml, *.robot - bootlint: .travis.yml *.html - html5validator: .travis.yml *.html Integration tests are executed always. Fix php-coder#423
bodom91
pushed a commit
to bodom91/mystamps
that referenced
this issue
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Most of our checks are checking only files with a certain type. We'll have a benefit if we run them only when user modified files with certain types.
Examples:
pom.xml
*.html
files*.html
files*.js
*.java
and*.groovy
filespom.xml
has changed*.groovy
files*.java
(and maybe*.properties
) filesThe text was updated successfully, but these errors were encountered: