Skip to content

/series/add: provide ability to download image from another server #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Jul 28, 2015 · 0 comments
Closed

/series/add: provide ability to download image from another server #199

php-coder opened this issue Jul 28, 2015 · 0 comments
Assignees
@php-coder
Labels
impact/changelog This change should be reflected in the NEWS.txt file kind/feature
Milestone
0.4

Comments

@php-coder
Copy link
Owner

php-coder commented Jul 28, 2015 •
edited
Loading

Requirements:

  • admin should fill one of the fields (URL or file)
  • all the existing validators that are currently applied to a file should be applied as well to a file which is downloaded by URL
  • it should be available on /series/add and on /series/{id} pages
@php-coder php-coder changed the title /series/add: provide ability to download image from other server /series/add: provide ability to download image from another server Aug 21, 2015
@php-coder php-coder added the impact/changelog This change should be reflected in the NEWS.txt file label Apr 26, 2016
@php-coder php-coder added this to the next milestone Jul 29, 2016
@php-coder php-coder self-assigned this Oct 6, 2016
@php-coder php-coder modified the milestones: 0.4, next Oct 6, 2016
@php-coder php-coder mentioned this issue May 17, 2017
Closed
29 tasks
php-coder added a commit that referenced this issue Jun 1, 2017
@php-coder
Modify image related validators to skip validation when image wasn't …
3820e8f 
…specified.

To make image field mandatory, @NotEmptyFilename validator should be used.

This change is required for #199 where image field will become an
optional.

No functional changes.
@php-coder php-coder mentioned this issue Aug 1, 2017
Closed
php-coder added a commit that referenced this issue Aug 1, 2017
@php-coder
/series/1: add an image also for a travis profile.
b01e997 
Correction for 646bb16 commit.

Addressed to #588
Required by #199
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
@php-coder @bodom91
Modify image related validators to skip validation when image wasn't …
188e711 
…specified.

To make image field mandatory, @NotEmptyFilename validator should be used.

This change is required for php-coder#199 where image field will become an
optional.

No functional changes.
This was referenced Oct 16, 2017
Open
Open
Closed
Closed
Open
Open
Open
Open
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
impact/changelog This change should be reflected in the NEWS.txt file kind/feature
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@php-coder