Skip to content

Update html5validator to 0.4.2 #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
php-coder opened this issue May 6, 2021 · 3 comments
Closed
4 tasks done

Update html5validator to 0.4.2 #1533

php-coder opened this issue May 6, 2021 · 3 comments
Assignees
@php-coder
Labels
ADR/needed A decision has been made and it needs to be documented area/ci kind/dependency-update Update one of dependencies
Milestone
0.4.7

Comments

@php-coder
Copy link
Owner

php-coder commented May 6, 2021 •
edited
Loading

@php-coder php-coder added this to the next milestone May 6, 2021
@php-coder php-coder modified the milestones: next, 0.4.7 Oct 18, 2021
@php-coder php-coder self-assigned this Oct 19, 2021
@php-coder php-coder changed the title Update html5validator to 0.4.0 Update html5validator to 0.4.2 Jun 20, 2022
@php-coder php-coder reopened this Jun 20, 2022
@php-coder
Copy link
Owner Author

It fails (https://app.travis-ci.com/github/php-coder/mystamps/jobs/574124836):

$ trap 'travis_terminate 1' ERR; if [ "$SPRING_PROFILES_ACTIVE" = 'travis' ]; then mysql -u root -e 'CREATE DATABASE mystamps CHARACTER SET utf8;'; mkdir -p /tmp/uploads /tmp/preview; cp src/main/resources/test/test.png /tmp/uploads/1.png; npm install -g [email protected]; pip install --user html5validator==0.4.2 ruamel.yaml.clib==0.2.2 robotframework==3.2.2 robotframework-lint==1.1 ansible==2.9.2 ansible-lint==4.2.0; if [ "$TRAVIS_PULL_REQUEST" != 'false' ]; then gem install danger:8.2.2 nokogiri:1.10.10 --no-document; fi; sudo apt-get -qq update; sudo apt-get install -y shellcheck; elif [ "$SPRING_PROFILES_ACTIVE" = 'postgres' ]; then psql -U postgres -c 'create database mystamps;'; fi
/home/travis/.nvm/versions/node/v8.12.0/bin/bootlint -> /home/travis/.nvm/versions/node/v8.12.0/lib/node_modules/bootlint/src/cli-main.js
+ [email protected]
added 51 packages from 22 contributors in 3.489s
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support pip 21.0 will remove support for this functionality.
Collecting html5validator==0.4.2
  Downloading html5validator-0.4.2.tar.gz (26.8 MB)
    ERROR: Command errored out with exit status 1:
     command: /usr/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-LOI9m7/html5validator/setup.py'"'"'; __file__='"'"'/tmp/pip-install-LOI9m7/html5validator/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-vxMjh0
         cwd: /tmp/pip-install-LOI9m7/html5validator/
    Complete output (10 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-LOI9m7/html5validator/setup.py", line 3, in <module>
        from html5validator import __version__
      File "html5validator/__init__.py", line 6, in <module>
        from .validator import Validator, JavaNotFoundException
      File "html5validator/validator.py", line 16
        DEFAULT_IGNORE_RE: List[str] = [
                         ^
    SyntaxError: invalid syntax
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

@php-coder
Copy link
Owner Author

It seems like from version 0.4.0 it requires python >= 3.6: svenkreiss/html5validator@0357674

@php-coder php-coder added the ADR/needed A decision has been made and it needs to be documented label Jul 9, 2022
php-coder added a commit that referenced this issue Jul 9, 2022
@php-coder
ci: install Python 3.6 that is required by newer version of html5vali…
0e09fac 
…dator to fix the build on TravisCI

This won't be necessary once we get newer Ubuntu on CI (see #1467)

See also:
- https://askubuntu.com/questions/865554/how-do-i-install-python-3-6-using-apt-get
- https://askubuntu.com/questions/889535/how-to-install-pip-for-python-3-6-on-ubuntu-16-10

Correction for 0132a12 commit.

Relate to #1533
@php-coder
Copy link
Owner Author

I've decided to install Python 3.6 to Travis CI (until we get it out-of-the-box in #1467)

php-coder added a commit that referenced this issue Jul 10, 2022
@php-coder
chore: mention installation of Python 3.6
aaa008e 
Relate to #1533

[skip ci]
php-coder added a commit that referenced this issue Dec 3, 2022
@php-coder
revert: "ci: install Python 3.6 that is required by newer version of …
d2110ff 
…html5validator to fix the build on TravisCI"

This reverts commit 0e09fac.

During migration to GitHub Actions (#1154), in commit 661444c we
have started to use containers with Ubuntu 20.04 that has Python 3.8.10 so this workaround isn't
needed anymore.

Relate to #1533
php-coder added a commit that referenced this issue Dec 3, 2022
@php-coder
chore: revert a workaround with Python 3.6 installation
4528547 
 Relate to #1533 and #1154

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
ADR/needed A decision has been made and it needs to be documented area/ci kind/dependency-update Update one of dependencies
Projects
None yet
Milestone
0.4.7
Development

No branches or pull requests
1 participant
@php-coder