Skip to content

Order of the series sales in PostgreSQL shows records without date first #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
php-coder opened this issue Jan 7, 2021 · 1 comment
Open

Order of the series sales in PostgreSQL shows records without date first #1492

php-coder opened this issue Jan 7, 2021 · 1 comment
Assignees
@php-coder
Labels
ADR/needed A decision has been made and it needs to be documented kind/bug
Milestone
0.5

Comments

@php-coder
Copy link
Owner

Addition of new tests in 52df7f3 (#498), reveal a difference in the order of sales in the series list -- it shows sales without dates (NULL) first on PostgreSQL.

Here is how the test fails:

FAIL: Robotframework.Series.Sales.Creation.Logic.Add a sale with all fields
The text of element 'id:series-sale-1-info' should have been '04.01.2021 Eicca Toppinen sold to Tommy Lee Jones for 7.50 EUR (10.10 USD) (MNH)', but it was 'Tommy Lee Jones was selling for 125.00 RUB'.

Seen there: https://travis-ci.com/github/php-coder/mystamps/jobs/468143974

I expect that the order it the same despite what the database is being used.
@php-coder php-coder added this to the 0.4.6 milestone Jan 7, 2021
@php-coder php-coder self-assigned this Jan 7, 2021
@php-coder
Copy link
Owner Author

Related links:

php-coder added a commit that referenced this issue Jan 7, 2021
@php-coder
chore: modify tests to use different series and avoid ordering issue …
bf3ea4d 
…on PostgreSQL

Addition of new tests in 52df7f3, reveal a difference in the order
of sales in the series list: on PostgreSQL sales without dates (NULL) are shown first.

This change apply a workaround for that issue by using different series to fix the build.

Address to #1492
@php-coder php-coder added the ADR/needed A decision has been made and it needs to be documented label Feb 1, 2021
@php-coder php-coder modified the milestones: 0.4.6, 0.4.7 Feb 14, 2021
@php-coder php-coder modified the milestones: 0.4.7, 0.5 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
ADR/needed A decision has been made and it needs to be documented kind/bug
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@php-coder