Skip to content

AddCommentForm: add tests #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0pdd opened this issue Jan 5, 2021 · 2 comments
Closed

AddCommentForm: add tests #1489

0pdd opened this issue Jan 5, 2021 · 2 comments
Assignees
@php-coder
Labels
area/frontend area/unit tests resolution/gone Non-reproducible, obsolete, outdated issues techdebt
Milestone
0.4.8

Comments

@0pdd
Copy link

0pdd commented Jan 5, 2021 •
edited by php-coder
Loading

The puzzle 1338-4f752b8a from #1338 has to be resolved:

mystamps/src/main/frontend/src/components/AddCommentForm.js

Line 6 in 7599f6b

// @todo #1338 AddCommentForm: add tests

The puzzle was created by Slava Semushin on 05-Jan-21.
@0pdd 0pdd added the techdebt label Jan 5, 2021
@php-coder
Copy link
Owner

This issue depends on #1484 where Jest and all required test dependencies will be added.

@php-coder php-coder self-assigned this Jan 10, 2021
@php-coder php-coder added this to the 0.4.6 milestone Jan 10, 2021
php-coder added a commit that referenced this issue Jan 11, 2021
@php-coder
test: add tests for AddCommentFormView
9cb6747 
Part of #1489
@0pdd 0pdd mentioned this issue Jan 11, 2021
Closed
@php-coder php-coder mentioned this issue Jan 20, 2021
Open
@php-coder php-coder modified the milestones: 0.4.6, 0.4.7 Feb 26, 2021
@php-coder php-coder modified the milestones: 0.4.7, 0.5 Oct 18, 2021
@php-coder php-coder mentioned this issue Jan 5, 2025
Open
@php-coder php-coder modified the milestones: 0.5, 0.4.8 Mar 17, 2025
@php-coder
Copy link
Owner

php-coder commented Mar 17, 2025 •
edited
Loading

Isn't needed in light of HTMX migration (#1671).

@php-coder php-coder closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2025
@php-coder php-coder added resolution/wontfix resolution/gone Non-reproducible, obsolete, outdated issues and removed resolution/wontfix labels Mar 17, 2025
php-coder added a commit that referenced this issue Mar 17, 2025
@php-coder
task: rewrite AddCommentForm to HTMX
6315235 
Closes #1489
Closes #1500
Closes #1544

Part of #1671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/frontend area/unit tests resolution/gone Non-reproducible, obsolete, outdated issues techdebt
Projects
None yet
Milestone
0.4.8
Development

No branches or pull requests
2 participants
@php-coder @0pdd