Skip to content

Don't put migrations for the new version into a directory for a released version #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Mar 2, 2020 · 1 comment
Closed

Don't put migrations for the new version into a directory for a released version #1265

php-coder opened this issue Mar 2, 2020 · 1 comment
Assignees
@php-coder
Labels
kind/bug refactoring trivial
Milestone
0.4.3

Comments

@php-coder
Copy link
Owner

At least the following were misplaced:

$ git diff 0.4.2..HEAD -- src/main/resources/liquibase/version/0.4.2.xml
diff --git a/src/main/resources/liquibase/version/0.4.2.xml b/src/main/resources/liquibase/version/0.4.2.xml
index cf1cc60c..dbf5df9c 100644
--- a/src/main/resources/liquibase/version/0.4.2.xml
+++ b/src/main/resources/liquibase/version/0.4.2.xml
@@ -7,5 +7,7 @@

        <include file="0.4.2/2019-11-17--drop_unique_series_from_collection.xml" relativeToChangelogFile="true" />
        <include file="0.4.2/2019-11-27--add_collections_series_id.xml" relativeToChangelogFile="true" />
+       <include file="0.4.2/2020-02-11--downloading_failed_import_requests.xml" relativeToChangelogFile="true" />
+       <include file="0.4.2/2020-02-12--empty_price_import_request.xml" relativeToChangelogFile="true" />

 </databaseChangeLog>
@php-coder php-coder added this to the 0.4.3 milestone Mar 2, 2020
@php-coder php-coder self-assigned this Mar 2, 2020
php-coder added a commit that referenced this issue Mar 6, 2020
@php-coder
refactor(2020-02-12--empty_price_import_request.xml): split a migrati…
250f917 
…on with test data into separate tables.

Part of #1265
Related to #1257
php-coder added a commit that referenced this issue Mar 6, 2020
@php-coder
refactor(2020-02-11--downloading_failed_import_requests.xml): split a…
70fd4bb 
… migration with test data into separate tables.

Part of #1265
Related to #1257
@php-coder
Copy link
Owner Author

Done.

@php-coder php-coder mentioned this issue Mar 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
kind/bug refactoring trivial
Projects
None yet
Milestone
0.4.3
Development

No branches or pull requests
1 participant
@php-coder