Skip to content

jacoco report generation is broken #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Jan 22, 2020 · 2 comments
Closed

jacoco report generation is broken #1239

php-coder opened this issue Jan 22, 2020 · 2 comments
Assignees
@php-coder
Labels
kind/bug kind/regression
Milestone
0.4.3

Comments

@php-coder
Copy link
Owner 

[INFO] --- jacoco-maven-plugin:0.8.5:report (default-cli) @ mystamps ---
[INFO] Skipping JaCoCo execution due to missing execution data file.
@php-coder php-coder added this to the 0.4.3 milestone Jan 22, 2020
@php-coder php-coder self-assigned this Jan 22, 2020
@php-coder
Copy link
Owner Author

php-coder commented Jan 22, 2020 •
edited
Loading

This is regression after aa43861 (#1164) where argLine has been moved.

@php-coder
Copy link
Owner Author

Here is the proposed fix:

@@ -917,7 +917,7 @@
                                                and doesn't pass it into a forked process.
                                                See: https://stackoverflow.com/questions/17656475/maven-source-encoding-in-utf-8-not-working
                                        -->
-                                       <argLine>-Dfile.encoding=${project.build.sourceEncoding} -Xss256k</argLine>
+                                       <argLine>@{argLine} -Dfile.encoding=${project.build.sourceEncoding} -Xss256k</argLine>
                                </configuration>
                        </plugin>

@php-coder php-coder mentioned this issue Jan 23, 2020
Closed
@php-coder php-coder reopened this Jan 23, 2020
php-coder added a commit that referenced this issue Jun 2, 2024
@php-coder
revert: "build: properly fix JaCoCo report generation."
af220cc 
This reverts commit 245ad38.

Relate to #1239
Part of #1672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
kind/bug kind/regression
Projects
None yet
Milestone
0.4.3
Development

No branches or pull requests
1 participant
@php-coder