Skip to content

Series import: respect page charset instead of to always use utf8 #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Jan 20, 2020 · 0 comments
Closed

Series import: respect page charset instead of to always use utf8 #1237

php-coder opened this issue Jan 20, 2020 · 0 comments
Assignees
@php-coder
Labels
kind/bug
Milestone
0.4.3

Comments

@php-coder
Copy link
Owner

For example, a page can be in windows-1251 charset and after treating it as utf8 it becomes non-readable and hence non-parsable.
@php-coder php-coder added this to the 0.4.3 milestone Jan 20, 2020
@php-coder php-coder self-assigned this Jan 20, 2020
php-coder added a commit that referenced this issue Jan 22, 2020
@php-coder
refactor(HttpURLConnectionDownloaderService): split validateConnectio…
fe20884 
…n() into validateResponseCode() and validateContentType().

Preliminary refactoring for #1237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
kind/bug
Projects
None yet
Milestone
0.4.3
Development

No branches or pull requests
1 participant
@php-coder