Skip to content

Series import: add support for alternative price #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Jan 19, 2020 · 0 comments
Closed

Series import: add support for alternative price #1230

php-coder opened this issue Jan 19, 2020 · 0 comments
Assignees
@php-coder
Labels
kind/improvement
Milestone
0.4.3

Comments

@php-coder
Copy link
Owner

php-coder commented Jan 19, 2020 •
edited
Loading

It should be possible to extract alternative price/currency.

Example:

m.w.f.s.i.SeriesInfoExtractorServiceImpl : Determine price from 'Новая цена 64.00 руб ($1.08 / €0.98)'
m.w.f.s.i.SeriesInfoExtractorServiceImpl : Price is 64.00

In this case, we can extract alternative price in USD (or EUR).

It should be added into 2 places: series import and series sale import.
@php-coder php-coder added this to the 0.4.3 milestone Jan 19, 2020
@php-coder php-coder self-assigned this Jan 19, 2020
php-coder added a commit that referenced this issue Mar 8, 2020
@php-coder
task: implement extraction and persistence of alternative price and c…
fea5123 
…urrency during a series import.

Part of #1230
@0pdd 0pdd mentioned this issue Mar 8, 2020
Closed
php-coder added a commit that referenced this issue Mar 9, 2020
@php-coder
task: show alternative price and currency during a series import.
16e54c8 
Also update the integration test to check for alternative price and currency.

Part of #1230
php-coder added a commit that referenced this issue Mar 9, 2020
@php-coder
task: implement extraction of alternative price and currency during a…
431dd2e 
… series sale import.

Part of #1230
@0pdd 0pdd mentioned this issue Mar 9, 2020
Open
This was referenced Mar 10, 2020
Closed
Closed
@php-coder php-coder mentioned this issue Mar 20, 2020
Closed
php-coder added a commit that referenced this issue Apr 12, 2020
@php-coder
refactor(series/info.html): update prototype to set alternative price…
f3b4ad5 
… and currency.

Should be in 431dd2e commit.

Relate to #1230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
kind/improvement
Projects
None yet
Milestone
0.4.3
Development

No branches or pull requests
1 participant
@php-coder