Skip to content

country: introduce a microservice #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
php-coder opened this issue Dec 5, 2019 · 2 comments
Open

country: introduce a microservice #1163

php-coder opened this issue Dec 5, 2019 · 2 comments
Assignees
@php-coder
Labels
area/infrastructure kind/task Task that is part of some feature refactoring
Milestone
next

Comments

@php-coder
Copy link
Owner

php-coder commented Dec 5, 2019 •
edited
Loading

Here is the list of CountryService methods that need to be ported/re-implemented:

Method Used by Outcome
add CountryController.processInput Need an endpoint: yes
findIdsByNames SeriesInfoExtractorServiceImpl.extractCountry ?
findIdsWhenNameStartsWith SeriesInfoExtractorServiceImpl.extractCountry ?
findAllAsLinkEntities CountryController.showCountries, SeriesController.addCountriesToModel and SeriesImportController ?
findOneAsLinkEntity CountryLinkEntityDtoConverter.convert and @Country (SeriesController, AddSeriesForm, ImportSeriesForm) ?
countAll SiteController.showIndexPage php-coder/mystamps-country#1
countCountriesOf CollectionController.showInfoBySlug Need an endpoint: yes
countBySlug UniqueCountrySlugValidator -> UniqueCountrySlug -> AddCountryForm Need an endpoint: no
countByName UniqueCountryNameValidator -> UniqueCountryName -> AddCountryForm Need an endpoint: no
countByNameRu UniqueCountryNameValidator -> UniqueCountryName -> AddCountryForm Need an endpoint: no
countAddedSince CronServiceImpl.getDailyReport -> ReportController.showDailyReport and CronServiceImpl.sendDailyStatistics ?
countUntranslatedNamesSince CronServiceImpl.getDailyReport -> ReportController.showDailyReport and CronServiceImpl.sendDailyStatistics ?
getStatisticsOf CollectionController.getCountriesStatistics ?
suggestCountryForUser SuggestionController.suggestCountryForUser Need an endpoint: yes

Part of #1162
@php-coder php-coder added refactoring area/infrastructure kind/task Task that is part of some feature labels Dec 5, 2019
@php-coder php-coder added this to the 0.4.3 milestone Dec 5, 2019
@php-coder php-coder self-assigned this Dec 5, 2019
@php-coder php-coder mentioned this issue Dec 5, 2019
Open
3 tasks
@php-coder
Copy link
Owner Author

The separate repo has been created: https://github.com/php-coder/mystamps-country

@php-coder
Copy link
Owner Author

I see there are SQL queries that works with series, collections and collections_series tables. These are the candidates to move to another package (service).

php-coder added a commit that referenced this issue Dec 11, 2019
@php-coder
refactor: introduce USE_COUNTRY_MICROSERVICE feature with implementat…
e004fa3 
…ion that delegates calls to a service.

Part of #1163
php-coder added a commit that referenced this issue Dec 12, 2019
@php-coder
refactor: move a country dao class into shared dao configutation.
0b32030 
Now JdbcCountryDaoTest doesn't depend on a service class and we can stop @ignore this test. This
removes a hack that has been added in e004fa3 commit (#1163).

Part of #1150
@php-coder php-coder modified the milestones: 0.4.3, 0.5 Mar 6, 2020
@php-coder php-coder modified the milestones: 0.5, next Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/infrastructure kind/task Task that is part of some feature refactoring
Projects
None yet
Milestone
next
Development

No branches or pull requests
1 participant
@php-coder