Skip to content

Migrate to JDK 11 #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
8 of 52 tasks
php-coder opened this issue Nov 27, 2019 · 3 comments
Open
8 of 52 tasks

Migrate to JDK 11 #1158

php-coder opened this issue Nov 27, 2019 · 3 comments
Assignees
@php-coder
Labels
area/build scripts area/infrastructure impact/changelog This change should be reflected in the NEWS.txt file kind/dependency-update Update one of dependencies priority/important-soon
Milestone
0.4.9

Comments

@php-coder
Copy link
Owner

php-coder commented Nov 27, 2019 •
edited
Loading

Related resources:
@php-coder php-coder added area/infrastructure impact/changelog This change should be reflected in the NEWS.txt file area/build scripts priority/important-soon kind/dependency-update Update one of dependencies labels Nov 27, 2019
@php-coder php-coder added this to the 0.5 milestone Nov 27, 2019
@php-coder php-coder self-assigned this Nov 27, 2019
@php-coder php-coder modified the milestones: 0.5, 0.4.3 Dec 2, 2019
@php-coder
Copy link
Owner Author

From https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-Versions:

Please upgrade to Spring Framework 5.1+ (and the corresponding Spring Boot 2.1+) for JDK 11+ support

So, we first should update Spring Boot to 2.1.x: #1161

@php-coder php-coder modified the milestones: 0.4.3, 0.5 Dec 5, 2019
@php-coder php-coder modified the milestones: 0.5, 0.4.4 Mar 17, 2020
@php-coder php-coder mentioned this issue Apr 17, 2020
Open
5 tasks
@php-coder php-coder modified the milestones: 0.4.4, next May 23, 2020
@php-coder php-coder mentioned this issue Sep 10, 2020
Closed
@php-coder php-coder modified the milestones: next, 0.4.6 Dec 2, 2020
@php-coder
Copy link
Owner Author

It seems like Groovy-related stuff requires some additional work in order to work with JDK11 (https://travis-ci.com/github/php-coder/mystamps/jobs/464914094):

  1. Unit tests fail to compile:

    [ERROR] Failed to execute goal org.codehaus.gmavenplus:gmavenplus-plugin:1.5:testCompile (default) on project mystamps: Error occurred while calling a method on a Groovy class from classpath. InvocationTargetException: BUG! exception in phase 'class generation' in source unit 'src/test/groovy/ru/mystamps/web/common/LocaleUtilsTest.groovy' unsupported Target MODULE -> [Help 1]

  2. CodeNarc doesn't fail a build but it throws an exception:

    [java] java.lang.reflect.InaccessibleObjectException: Unable to make jdk.internal.loader.ClassLoaders$AppClassLoader(jdk.internal.loader.ClassLoaders$PlatformClassLoader,jdk.internal.loader.URLClassPath) accessible: module java.base does not "opens jdk.internal.loader" to unnamed module @271053e1

  3. Integration test fail but it seem like that it was caused by unit tests:

    [ERROR] Failed to execute goal org.codehaus.gmavenplus:gmavenplus-plugin:1.5:testCompile (default) on project mystamps: Error occurred while calling a method on a Groovy class from classpath. InvocationTargetException: BUG! exception in phase 'class generation' in source unit '/home/travis/build/php-coder/mystamps/src/test/groovy/ru/mystamps/web/common/LocaleUtilsTest.groovy' unsupported Target MODULE -> [Help 1]

Instead of finding a fix for Groovy code (perhaps, updating it), I suggest to migrate unit tests to JUnit (#1246) first.

@php-coder php-coder modified the milestones: 0.4.6, next Jan 1, 2021
@php-coder
Copy link
Owner Author

Notes to myself:

  • JFR (Java Flight Recorder) + JMC (Java Mission Control)
  • String compaction
  • AppCDS (Application Class Data Sharing)

@php-coder php-coder modified the milestones: 0.4.6, next Jan 31, 2021
@php-coder php-coder mentioned this issue Jan 22, 2022
Open
26 tasks
@php-coder php-coder mentioned this issue Jun 15, 2022
Open
6 tasks
php-coder added a commit that referenced this issue Jun 15, 2022
@php-coder
build: update HikariCP to 4.0.3
ad81434 
Changelog: https://github.com/brettwooldridge/HikariCP/blob/HikariCP-4.0.3/CHANGES

Update to 5.x version requires JDK11 (#1158)

Part of #1509
@php-coder php-coder mentioned this issue Jul 9, 2022
Closed
@php-coder php-coder modified the milestones: next, 0.4.8 Jul 27, 2023
@php-coder php-coder mentioned this issue Dec 6, 2023
Open
9 tasks
php-coder added a commit that referenced this issue Dec 27, 2023
@php-coder
ci: execute integration tests on H2 also under Java 11 and 17
d1fd249 
Part of #1350 #1158 #1556
php-coder added a commit that referenced this issue Dec 27, 2023
@php-coder
chore: fix "A mapping was not expected" error
2ac5106 
See actions/runner#2289 (comment)

Corrections for d1fd249 commit.

Relate to #1350 #1158 #1556
php-coder added a commit that referenced this issue Dec 27, 2023
@php-coder
chore: really run on JDK 11 and 17
123e768 
Corrections for d1fd249 commit.

Relate to #1350 #1158 #1556
@php-coder php-coder mentioned this issue Dec 27, 2023
Closed
28 tasks
php-coder added a commit that referenced this issue Dec 28, 2023
@php-coder
build: fix "Warning: bootstrap class path not set in conjunction with…
586db5d 
… -source 8" on JDK 11 and 17

Part of #1350 #1158 #1556
@php-coder php-coder modified the milestones: 0.4.8, 0.4.9 Dec 29, 2023
@php-coder php-coder mentioned this issue Oct 20, 2024
Open
@php-coder php-coder mentioned this issue Jan 16, 2025
Open
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/build scripts area/infrastructure impact/changelog This change should be reflected in the NEWS.txt file kind/dependency-update Update one of dependencies priority/important-soon
Projects
None yet
Milestone
0.4.9
Development

No branches or pull requests
1 participant
@php-coder