Skip to content

html5validator emits a lot of warnings after update #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Nov 24, 2019 · 2 comments
Closed

html5validator emits a lot of warnings after update #1156

php-coder opened this issue Nov 24, 2019 · 2 comments
Assignees
@php-coder
Labels
ADR/needed A decision has been made and it needs to be documented area/build scripts kind/bug kind/regression
Milestone
0.4.2

Comments

@php-coder
Copy link
Owner

There is a lot of new warnings after updating to html5validator to 0.3.2: https://travis-ci.org/php-coder/mystamps/jobs/616310191

Let's fix them. Also pin the version of html5validator to make build stable. Also we need to find out why warning didn't fail a build.
@php-coder php-coder added this to the 0.4.2 milestone Nov 24, 2019
@php-coder php-coder self-assigned this Nov 24, 2019
@php-coder
Copy link
Owner Author

There is a lot of new warnings after updating to html5validator to 0.3.2

It's html5validator regression: svenkreiss/html5validator#64

@php-coder
Copy link
Owner Author

Also we need to find out why warning didn't fail a build.

It were errors actually and it's not clear why it didn't fail indeed. I'll look on it later.

@php-coder php-coder added the ADR/needed A decision has been made and it needs to be documented label Feb 9, 2020
@php-coder php-coder mentioned this issue Dec 20, 2020
Closed
2 tasks
php-coder added a commit that referenced this issue Jan 15, 2021
@php-coder
chore(docs/decision-log.md): mention a fix of html5validator's regres…
700622a 
…sion

Relate to #11169 and #1156

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
ADR/needed A decision has been made and it needs to be documented area/build scripts kind/bug kind/regression
Projects
None yet
Milestone
0.4.2
Development

No branches or pull requests
1 participant
@php-coder