Skip to content

User can add multiple instances of a series into a collection #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
11 tasks done
php-coder opened this issue Sep 19, 2019 · 3 comments
Closed
11 tasks done

User can add multiple instances of a series into a collection #1123

php-coder opened this issue Sep 19, 2019 · 3 comments
Assignees
@php-coder
Labels
impact/changelog This change should be reflected in the NEWS.txt file kind/feature
Milestone
0.4.2

Comments

@php-coder
Copy link
Owner

php-coder commented Sep 19, 2019 •
edited
Loading

To be done:

  • relax constraints on database level (/collection/{slug}: exception happens when user adds a series to collection that already has this series #986)
  • make it possible to add more than one instance of a series
  • update a view to show a list of series
  • make it possible to delete only one instance of a series from a collection
  • protect deletion against removing someone's else instance (we've already protected by the SQL query that we use)
  • don't show "New" badge multiple times (I'll deal with it in a separate issue)
  • customize "Series isn't part of your collection" message => "Add another one instance of this series to collection"
  • integration test
    • the form is visible again
    • the message has been changed
    • a number of stamps is displayed
@php-coder php-coder added this to the 0.4.2 milestone Sep 19, 2019
@php-coder php-coder pinned this issue Nov 17, 2019
@php-coder php-coder self-assigned this Nov 17, 2019
php-coder added a commit that referenced this issue Nov 18, 2019
@php-coder
task(/series/{id}): show a form for adding a series even when user al…
32829ec 
…ready has this series.

Part of #1123
@php-coder
Copy link
Owner Author

It seems like using UUID type isn't good idea:

php-coder added a commit that referenced this issue Nov 28, 2019
@php-coder
refactor(series/info.html): move the paragraphs out of a form.
9f6bb54 
Prerequsite for #1123
@php-coder php-coder added impact/changelog This change should be reflected in the NEWS.txt file and removed in progress labels Nov 30, 2019
php-coder added a commit that referenced this issue Dec 2, 2019
@php-coder
task: add collections_series.id field to make possible to distinguish…
2675e9f 
… different instaces of a series.

This change is required for separate removal of a series instances from a collection.

Part of #1123
php-coder added a commit that referenced this issue Dec 2, 2019
@php-coder
chore(0.4.2/2019-11-27--add_collections_series_id.xml): fix migration…
feca32f 
… on MySQL.

The error was:
liquibase.exception.ValidationFailedException: Validation Failed:
  1 changes have validation failures
    Cannot add a non-primary key identity column, classpath:/liquibase/version/0.4.2/2019-11-27--add_collections_series_id.xml::add-collections_series-id-field::php-coder

Use a single <addColumn> statement for MySQL/PostgreSQL and perform it in the 2 steps for H2.
Also remove beforeColumn that didn't work -- MySQL doesn't support it so we use FIRST clause
instead. PostgreSQL doesn't support defining a column position at all. For H2 use FIRST as well.

Correction for 2675e9f commit.

Address to #1123
@php-coder php-coder unpinned this issue Dec 28, 2019
@php-coder php-coder mentioned this issue Dec 28, 2019
Open
This was referenced Dec 28, 2019
Open
Closed
@0pdd
Copy link

0pdd commented Dec 28, 2019

@php-coder 2 puzzles #1193, #1194 are still not solved.

@php-coder
Copy link
Owner Author

/spent 8h57m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
impact/changelog This change should be reflected in the NEWS.txt file kind/feature
Projects
None yet
Milestone
0.4.2
Development

No branches or pull requests
2 participants
@php-coder @0pdd