Add integration tests for search by a catalog in user's collection

[0pdd]

The puzzle 673-67e9da55 from #673 has to be resolved:

mystamps/src/main/webapp/WEB-INF/views/site/index.html

Line 185 in 9778afa

<!-- @todo #673 Add integration tests for search by a catalog in user's collection -->

The puzzle was created by Mukesh Katariya on 22-Jul-19.

[mukeshk]

How do we enable the feature in the test case?

[php-coder]

That's a good question, let's enable it then! (To make life easier to us.)

[mukeshk]

Are this test-cases scenario good?

-search\access
`An Anonymous user cannot request search in his collection
Page Should Not Contain Element id=in-collection

An Authorized user can request search in his collection
Log In As login=admin password=test
Page Should Not Contain Element id=in-collection`

- search\validation
Search in my collection is unchecked on load Log In As login=admin password=test Checkbox Should Not Be Selected id=in-collection

[mukeshk]

What would be the test data set for "no search result" in my collection?
admin/test - any catalogue - result in no result

What would be the test data set for "search result" to have some data for in my collection search?

[mukeshk]

Please suggest

[php-coder]

@mukeshk I'm looking on it right now :)

[php-coder]

1. we need to test the same cases as we have for an anonymous user -- nothing found and something found. No need to test anything else
2. let's put these cases into src/test/robotframework/series/search/logic-user.robot
3. let's use user "coder" user for tests (not "admin")

What would be the test data set for "no search result" in my collection?

use the same data as for anonymous user (just copy&paste + we need to check a checkbox)

What would be the test data set for "search result" to have some data for in my collection search?

use the same data as for anonymous user (just copy&paste + we need to check a checkbox) -- it should work AFAIR because user "coder" has series #1 in his collection

[mukeshk]

with coder/test account.
I am looking for a CatalogName and CatalogNumber for which I will get the result when I check "in my collection" and "no result" when checked is false.

So the test case differs only in checkbox flag.
What is the Catalog Name and Number for this test case scenario?

[php-coder]

So the test case differs only in checkbox flag.

Actually, no. The checkbox is always selected. They differ by catalog name/number.

What is the Catalog Name and Number for this test case scenario?

That's a great question! I've checked and see that "coder" has no series in his collection. That means that we can't use this user for this test and have to create another one.

So, we need:

1. create a test user who has series with id=1 in this collection
2. add 2 test cases similar to Search series by non-existing catalog number and Search series by existing catalog number but with checkbox activated

Let me know if you need help/guidance here.

[mukeshk]

1.create a test user who has series with id=1 in this collection
How do we do this? I see something in test-data.properties but not fully aware of how it translates into SQL scripts?

Also, can you put together something on the data model - any diagram, data dictionary to explain the DB design. Not immediately though :).

[php-coder]

Thanks for the response! There 2 ways -- slow (when you wait the full instructions) and a little faster (where I give you pointers, you try, I help you to remove roadblocks and after few iterations we have make it working). Which one do you prefer?

[mukeshk]

I will prefer the faster one, I will love to work my way through understand things. Unless you prefer to start some other task.

…

On Fri 2 Aug, 2019, 3:07 PM Slava Semushin, ***@***.***> wrote: Thanks for the response! There 2 ways -- slow (when you wait the full instructions) and a little faster (where I give you pointers, you try, I help you to remove roadblocks and after few iterations we have make it working). Which one do you prefer? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1097?email_source=notifications&email_token=AAJPE6GYQOTSKJARSL7HMI3QCP54PA5CNFSM4IF3ZPS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3NHVYA#issuecomment-517634784>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJPE6HEQ2JM42VS6K4PMM3QCP54PANCNFSM4IF3ZPSQ> .

[php-coder]

So, the first step is to add a test user that will have a series in his collection. We need to add a new database migration.

• here is an example on how to create a user and his collection:
  

  mystamps/src/main/resources/liquibase/version/0.4/2017-01-06--top_categories.xml

  Lines 59 to 72 in 3914aa1

  	<insert tableName="users">
  	<column name="login" value="admin" />
  	<column name="role" value="ADMIN" />
  	<column name="name" value="Admin" />
  	<column name="email" value="root@localhost" />
  	<column name="hash" value="no-password" />
  	<column name="registered_at" valueComputed="${NOW}" />
  	<column name="activated_at" valueComputed="${NOW}" />
  	</insert>
  	<insert tableName="collections">
  	<column name="user_id" valueComputed="(SELECT id FROM users WHERE login = 'admin')" />
  	<column name="slug" value="admin" />
  	</insert>

  
  Here we need a real hash for password in order to be able to log in later. Let's use valid_user_password_hash from test-data.properties

• in order to add a series to user's collection, we need to add a record to collections_series table.

If you want to play with database, try the following:

• open http://localhost:8080/console
• use "org.h2.Driver" as the driver
• use "jdbc:h2:mem:mystamps" as the URL
• use "sa" as the username and a blank password

There you will see the current state of database, all the tables and you might play with queries in order to make everything work.

[mukeshk]

1. I have created a new User.
2. I have created a new Collection.
3. I have created a record in collection_series with an existing series.

I build a SQL script by looking at other scripts.
I assume I need to put the SQL under 0.4.1 version in liquibase.

Am I correct?
Apologize for the delay was stuck in some other work.

[php-coder]

Yes, everything sounds good. Let's continue the discussion in PR ;-)