Skip to content

Use minified version of SeriesSaleImportForm.js #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0pdd opened this issue Jul 11, 2019 · 2 comments
Closed

Use minified version of SeriesSaleImportForm.js #1075

0pdd opened this issue Jul 11, 2019 · 2 comments

Comments

@0pdd
Copy link

0pdd commented Jul 11, 2019

The puzzle 1057-a9217ba4 from #1057 has to be resolved:

// @todo #1057 Use minified version of SeriesSaleImportForm.js

The puzzle was created by Slava Semushin on 23-Jun-19.

@php-coder
Copy link
Owner

At this moment, minify-maven-plugin fails to minify JS code produced by Babel:

[INFO] Creating the minified file [SeriesSaleImportForm.min.js].
[ERROR] missing name after . operator at SeriesSaleImportForm.js line 56:12
			}).catch(function (error) {
			         ^

[ERROR] missing } after property list at SeriesSaleImportForm.js line 58:5
			});
			  ^

[ERROR] syntax error at SeriesSaleImportForm.js line 64:2
	}, {
	 ^

[ERROR] syntax error at SeriesSaleImportForm.js line 65:7
		key: 'render',
		     ^

[ERROR] syntax error at SeriesSaleImportForm.js line 66:9
		value: function render() {
		       ^

[ERROR] syntax error at SeriesSaleImportForm.js line 143:3
		}
		 ^

[ERROR] syntax error at SeriesSaleImportForm.js line 144:3
	}]);
	  ^

[ERROR] invalid return at SeriesSaleImportForm.js line 146:8
	return SeriesSaleImportForm;
	       ^

[ERROR] syntax error at SeriesSaleImportForm.js line 147:1
}(React.Component);
 ^

[ERROR] Compilation produced 9 syntax errors.

@php-coder php-coder added this to the 0.4.2 milestone Sep 9, 2019
@php-coder php-coder modified the milestones: 0.4.2, next Nov 6, 2019
@php-coder
Copy link
Owner

The same should be done for SimilarSeriesForm.js that has been added in 1391152 (#1280)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants