Skip to content

Replace Hamcrest by AssertJ #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Jun 6, 2019 · 1 comment
Closed

Replace Hamcrest by AssertJ #1035

php-coder opened this issue Jun 6, 2019 · 1 comment
Assignees
@php-coder
Labels
area/unit tests refactoring
Milestone
0.4.2

Comments

@php-coder
Copy link
Owner

No description provided.

@php-coder php-coder added this to the 0.4.2 milestone Sep 9, 2019
@php-coder php-coder self-assigned this Oct 31, 2019
php-coder added a commit that referenced this issue Oct 31, 2019
@php-coder
refactor(JsoupSiteParserTest): use AssertJ instead of Hamcrest for as…
099d859 
…sertions.

See also:
- https://assertj.github.io/doc/#assertj-core-quick-start
- https://www.baeldung.com/introduction-to-assertj

Part of #1035
php-coder added a commit that referenced this issue Oct 31, 2019
@php-coder
refactor(ContentSecurityPolicyHeaderWriterTest): use AssertJ instead …
26e8d18 
…of Hamcrest for assertions.

Part of #1035
@php-coder
Copy link
Owner Author

Done.

php-coder added a commit that referenced this issue Dec 18, 2019
@php-coder
chore(NEWS.txt): mention that unit tests have been migrated to AssertJ.
b33d6ca 
Address to #1035

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/unit tests refactoring
Projects
None yet
Milestone
0.4.2
Development

No branches or pull requests
1 participant
@php-coder