Skip to content

SeriesSalesImportServiceImpl.downloadAndParse(): add unit tests #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1668
0pdd opened this issue Jun 3, 2019 · 1 comment
Closed
Tracked by #1668

SeriesSalesImportServiceImpl.downloadAndParse(): add unit tests #1028

0pdd opened this issue Jun 3, 2019 · 1 comment
Assignees
@php-coder
Labels
area/unit tests resolution/wontfix techdebt
Milestone
0.4.8

Comments

@0pdd
Copy link

0pdd commented Jun 3, 2019 •
edited by php-coder
Loading

The puzzle 995-950efed9 from #995 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/feature/series/importing/sale/SeriesSalesImportServiceImpl.java

Line 42 in bc3fe55

// @todo #995 SeriesSalesImportServiceImpl.downloadAndParse(): add unit tests

The puzzle was created by Slava Semushin on 03-Jun-19.
@0pdd 0pdd added the techdebt label Jun 3, 2019
0pdd referenced this issue Jun 3, 2019
@php-coder
feat: implement import of a series sales by URL.
bc3fe55 
Implementation details:
- /series/{id}: a new form for importing a series sale has been added.
  It's only available when ADD_PURCHASES_AND_SALES Togglz feature is
  active and user has IMPORT_SERIES_SALES authority
- IMPORT_SERIES_SALES authority has been added and granted to admin user
  by default
- migration: JacksonAutoConfiguration should be removed from
  spring.autoconfigure.exclude property in application*.properties file

Fix #995
@0pdd 0pdd mentioned this issue Jun 3, 2019
Closed
@php-coder php-coder mentioned this issue Mar 11, 2024
Open
71 tasks
@php-coder php-coder self-assigned this Mar 14, 2024
@php-coder php-coder added this to the 0.4.8 milestone Mar 14, 2024
@php-coder
Copy link
Owner

Closed by 68030d2 commit.

@php-coder php-coder closed this as not planned Won't fix, can't repro, duplicate, stale Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/unit tests resolution/wontfix techdebt
Projects
None yet
Milestone
0.4.8
Development

No branches or pull requests
2 participants
@php-coder @0pdd