Skip to content

Commit 68030d2

Browse files
committed
test: remove tests for SeriesSalesImportServiceImpl class
Part of #1668
1 parent da0d240 commit 68030d2

File tree

4 files changed

+0
-157
lines changed

4 files changed

+0
-157
lines changed

src/main/java/ru/mystamps/web/feature/series/importing/sale/SeriesSalesImportServiceImpl.java

-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ public class SeriesSalesImportServiceImpl implements SeriesSalesImportService {
3939
private final SiteParserService siteParserService;
4040
private final SeriesInfoExtractorService extractorService;
4141

42-
// @todo #995 SeriesSalesImportServiceImpl.downloadAndParse(): add unit tests
4342
@Override
4443
@Transactional(readOnly = true)
4544
@PreAuthorize(HasAuthority.IMPORT_SERIES)

src/test/groovy/ru/mystamps/web/feature/series/importing/sale/SeriesSalesImportServiceImplTest.groovy

-99
This file was deleted.

src/test/java/ru/mystamps/web/service/TestObjects.java

-52
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,12 @@
2424
import ru.mystamps.web.feature.account.UsersActivationFullDto;
2525
import ru.mystamps.web.feature.image.ImageDto;
2626
import ru.mystamps.web.feature.image.ImageInfoDto;
27-
import ru.mystamps.web.feature.series.importing.sale.SeriesSaleParsedDataDto;
28-
import ru.mystamps.web.feature.series.importing.sale.SeriesSalesParsedDataDbDto;
2927
import ru.mystamps.web.feature.site.SuspiciousActivityDto;
3028
import ru.mystamps.web.tests.Random;
3129

3230
import java.nio.charset.StandardCharsets;
3331
import java.util.Date;
3432

35-
import static io.qala.datagen.RandomShortApi.bool;
36-
import static io.qala.datagen.RandomShortApi.nullOr;
37-
3833
public final class TestObjects {
3934
public static final String TEST_ACTIVITY_TYPE = "EventType";
4035
public static final String TEST_ACTIVITY_PAGE = "http://example.org/some/page";
@@ -121,51 +116,4 @@ public static SuspiciousActivityDto createSuspiciousActivityDto() {
121116
);
122117
}
123118

124-
public static SeriesSalesParsedDataDbDto createSeriesSalesParsedDataDbDto() {
125-
SeriesSalesParsedDataDbDto dto = new SeriesSalesParsedDataDbDto();
126-
127-
boolean existingSeller = bool();
128-
if (existingSeller) {
129-
dto.setSellerId(Random.id());
130-
} else {
131-
dto.setSellerName(Random.sellerName());
132-
dto.setSellerUrl(Random.url());
133-
}
134-
135-
dto.setPrice(Random.price());
136-
dto.setCurrency(Random.currency().toString());
137-
dto.setCreatedAt(Random.date());
138-
dto.setUpdatedAt(Random.date());
139-
return dto;
140-
}
141-
142-
public static SeriesSaleParsedDataDto createSeriesSaleParsedDataDto() {
143-
Integer sellerId = null;
144-
Integer sellerGroupId = null;
145-
String sellerName = null;
146-
String sellerUrl = null;
147-
148-
boolean existingSeller = bool();
149-
if (existingSeller) {
150-
sellerId = Random.id();
151-
} else {
152-
sellerGroupId = Random.id();
153-
sellerName = Random.sellerName();
154-
sellerUrl = Random.url();
155-
}
156-
157-
return new SeriesSaleParsedDataDto(
158-
sellerId,
159-
sellerGroupId,
160-
sellerName,
161-
sellerUrl,
162-
Random.price(),
163-
Random.currency(),
164-
Random.price(),
165-
// FIXME: alternative currency shouldn't match with currency
166-
Random.currency(),
167-
nullOr(Random.seriesCondition())
168-
);
169-
}
170-
171119
}

src/test/java/ru/mystamps/web/tests/Random.java

-5
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import ru.mystamps.web.feature.country.CountryValidation;
2828
import ru.mystamps.web.feature.participant.ParticipantValidation;
2929
import ru.mystamps.web.feature.series.SeriesValidation;
30-
import ru.mystamps.web.feature.series.sale.SeriesCondition;
3130
import ru.mystamps.web.feature.site.SiteUrl;
3231

3332
import java.math.BigDecimal;
@@ -101,10 +100,6 @@ public static Currency currency() {
101100
return sample(Currency.values());
102101
}
103102

104-
public static SeriesCondition seriesCondition() {
105-
return sample(SeriesCondition.values());
106-
}
107-
108103
public static String url() {
109104
final long minLength = 5;
110105
final long maxLength = 15;

0 commit comments

Comments
 (0)