Skip to content

/series/sales/import: validate that we have a parser for this url #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0pdd opened this issue Jun 3, 2019 · 2 comments
Closed

/series/sales/import: validate that we have a parser for this url #1027

0pdd opened this issue Jun 3, 2019 · 2 comments
Assignees
@php-coder
Labels
area/validation techdebt
Milestone
0.4.1

Comments

@0pdd
Copy link

0pdd commented Jun 3, 2019 •
edited by php-coder
Loading

The puzzle 995-f9b468d5 from #995 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/feature/series/importing/RequestImportForm.java

Line 42 in bc3fe55

// @todo #995 /series/sales/import: validate that we have a parser for this url

The puzzle was created by Slava Semushin on 03-Jun-19.
@0pdd 0pdd added the techdebt label Jun 3, 2019
0pdd referenced this issue Jun 3, 2019
@php-coder
feat: implement import of a series sales by URL.
bc3fe55 
Implementation details:
- /series/{id}: a new form for importing a series sale has been added.
  It's only available when ADD_PURCHASES_AND_SALES Togglz feature is
  active and user has IMPORT_SERIES_SALES authority
- IMPORT_SERIES_SALES authority has been added and granted to admin user
  by default
- migration: JacksonAutoConfiguration should be removed from
  spring.autoconfigure.exclude property in application*.properties file

Fix #995
@0pdd 0pdd mentioned this issue Jun 3, 2019
Closed
@php-coder
Copy link
Owner

Possible error message: "Import from the provided site isn't supported".

@php-coder php-coder self-assigned this Jul 14, 2019
@php-coder php-coder added this to the 0.4.1 milestone Jul 14, 2019
@0pdd 0pdd mentioned this issue Jul 14, 2019
Closed
@0pdd
Copy link
Author

0pdd commented Jul 14, 2019

@0pdd the puzzle #1079 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/validation techdebt
Projects
None yet
Milestone
0.4.1
Development

No branches or pull requests
2 participants
@php-coder @0pdd