Skip to content

Commit b164b65

Browse files
committed
Introduce and use RawParsedDataDto.withImageUrl() method.
Fix #848 No functional changes.
1 parent 16a1953 commit b164b65

File tree

2 files changed

+18
-25
lines changed

2 files changed

+18
-25
lines changed

src/main/java/ru/mystamps/web/service/dto/RawParsedDataDto.java

+16
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,20 @@ public class RawParsedDataDto {
3333
private final String sellerUrl;
3434
private final String price;
3535
private final String currency;
36+
37+
public RawParsedDataDto withImageUrl(String url) {
38+
return new RawParsedDataDto(
39+
categoryName,
40+
countryName,
41+
url,
42+
releaseYear,
43+
quantity,
44+
perforated,
45+
sellerName,
46+
sellerUrl,
47+
price,
48+
currency
49+
);
50+
}
51+
3652
}

src/test/groovy/ru/mystamps/web/service/SeriesImportServiceImplTest.groovy

+2-25
Original file line numberDiff line numberDiff line change
@@ -420,19 +420,7 @@ class SeriesImportServiceImplTest extends Specification {
420420
given:
421421
Integer expectedRequestId = Random.id()
422422
and:
423-
// @todo #695 Introduce and use RawParsedDataDto.withImageUrl() method
424-
RawParsedDataDto rawData = new RawParsedDataDto(
425-
Random.categoryName(),
426-
Random.countryName(),
427-
null, /* imageUrl */
428-
Random.issueYear().toString(),
429-
Random.quantity().toString(),
430-
String.valueOf(Random.perforated()),
431-
Random.sellerName(),
432-
Random.url(),
433-
String.valueOf(Random.price()),
434-
Random.currency().toString()
435-
)
423+
RawParsedDataDto rawData = TestObjects.createRawParsedDataDto().withImageUrl(null)
436424
and:
437425
extractorService.extract(_ as RawParsedDataDto) >> TestObjects.createEmptySeriesExtractedInfo()
438426
when:
@@ -450,18 +438,7 @@ class SeriesImportServiceImplTest extends Specification {
450438
Integer expectedRequestId = Random.id()
451439
String expectedImageUrl = Random.url()
452440
and:
453-
RawParsedDataDto rawData = new RawParsedDataDto(
454-
Random.categoryName(),
455-
Random.countryName(),
456-
expectedImageUrl,
457-
Random.issueYear().toString(),
458-
Random.quantity().toString(),
459-
String.valueOf(Random.perforated()),
460-
Random.sellerName(),
461-
Random.url(),
462-
String.valueOf(Random.price()),
463-
Random.currency().toString()
464-
)
441+
RawParsedDataDto rawData = TestObjects.createRawParsedDataDto().withImageUrl(expectedImageUrl)
465442
and:
466443
extractorService.extract(_ as RawParsedDataDto) >> TestObjects.createEmptySeriesExtractedInfo()
467444
when:

0 commit comments

Comments
 (0)