Skip to content

Commit 16a1953

Browse files
committed
JsoupSiteParser.extractSellerUrl(): add unit tests.
Fix #843
1 parent c89fd0f commit 16a1953

File tree

2 files changed

+38
-1
lines changed

2 files changed

+38
-1
lines changed

src/main/java/ru/mystamps/web/util/extractor/JsoupSiteParser.java

-1
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,6 @@ protected String extractSellerName(Element body) {
256256
return sellerName;
257257
}
258258

259-
// @todo #695 JsoupSiteParser.extractSellerUrl(): add unit tests
260259
protected String extractSellerUrl(Element body) {
261260
if (sellerLocator == null) {
262261
return null;

src/test/java/ru/mystamps/web/util/extractor/JsoupSiteParserTest.java

+38
Original file line numberDiff line numberDiff line change
@@ -825,6 +825,44 @@ public void extractSellerNameShouldReturnTextOfSellerLocator() {
825825
assertThat(msg, name, equalTo(expectedValue));
826826
}
827827

828+
//
829+
// Tests for extractSellerUrl()
830+
//
831+
832+
@Test
833+
public void extractSellerUrlShouldReturnNullWhenSellerLocatorIsNotSet() {
834+
parser.setSellerLocator(null);
835+
Element doc = createEmptyDocument();
836+
837+
String url = parser.extractSellerUrl(doc);
838+
839+
assertThat(url, is(nullValue()));
840+
}
841+
842+
@Test
843+
public void extractSellerUrlShouldReturnNullWhenElementNotFound() {
844+
parser.setSellerLocator(Random.jsoupLocator());
845+
Element doc = createEmptyDocument();
846+
847+
String url = parser.extractSellerUrl(doc);
848+
849+
assertThat(url, is(nullValue()));
850+
}
851+
852+
@Test
853+
public void extractSellerUrlShouldReturnValueOfHrefAttribute() {
854+
parser.setSellerLocator("a");
855+
856+
String expectedUrl = Random.url();
857+
String html = String.format("<a href='%s'>test</a>", expectedUrl);
858+
Element doc = createDocumentFromText(html);
859+
860+
String url = parser.extractSellerUrl(doc);
861+
862+
String msg = String.format("couldn't extract seller url from '%s'", doc);
863+
assertThat(msg, url, equalTo(expectedUrl));
864+
}
865+
828866
//
829867
// Tests for extractPrice()
830868
//

0 commit comments

Comments
 (0)